From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add freeimage.
Date: Sun, 02 Nov 2014 18:26:54 +0100
Message-ID: <87mw89ms2p.fsf@gnu.org>
References: <87egtmx6ox.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<20141101165950.GA10580@debian>
	<87bnoqx2do.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XkyvG-0003KZ-CP
	for guix-devel@gnu.org; Sun, 02 Nov 2014 12:26:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XkyvB-0001mq-Aq
	for guix-devel@gnu.org; Sun, 02 Nov 2014 12:26:38 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:44006)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XkyvB-0001ml-3a
	for guix-devel@gnu.org; Sun, 02 Nov 2014 12:26:33 -0500
In-Reply-To: <87bnoqx2do.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Sat, 01 Nov 2014 13:21:55 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> Andreas Enge <andreas@enge.fr> writes:

[...]

>>> +                'unpack
>>> +                (lambda* (#:key source #:allow-other-keys)
>>> +                  (and (zero? (system* "unzip" source))
>>> +                       (chdir "FreeImage")))
>>
>> I wonder if this should not be moved to the standard unpack phase. Can we
>> determine the file format and use the appropriate tool, unzip or tar,
>> automatically? (Assuming that there are no .tar.zip out there, of
>> course.)
>
> I've been thinking about this, too.  I don't think I would like the GNU
> build system to depend on unzip since very few packages require it and
> it's not a format that GNU uses, but maybe a procedure that replaced the
> standard unpack phase with one that uses unzip would be nice.  I think
> that work could/should be saved for a future patch.

I think we could change =E2=80=98unpack=E2=80=99 in gnu-build-system.scm to=
 invoke unzip
when the file name ends in .zip, while letting it the user=E2=80=99s
responsibility to add unzip as an input when needed (as is already the
case for lzip.)

But yes, this would be for core-updates.

> From 2972e6e41d7c13dd619f0dd7fbda7b2a4ec0c6cc Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Wed, 25 Jun 2014 19:50:30 -0400
> Subject: [PATCH] gnu: Add freeimage.
>
> * gnu/packages/image.scm (freeimage): New variable.

LGTM, OK to push!

Ludo=E2=80=99.