From: Mark H Weaver <mhw@netris.org>
To: Taylan Ulrich Kammer <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org, Alex Vorobiev <alexander.vorobiev@gmail.com>
Subject: Re: --with-store-dir and/or --localstatedir seem to be ignored
Date: Tue, 19 May 2015 18:17:23 -0400 [thread overview]
Message-ID: <87mw10mcuk.fsf@netris.org> (raw)
In-Reply-To: <87d222ey57.fsf@gmail.com> (Taylan Ulrich Kammer's message of "Fri, 15 May 2015 16:03:16 +0200")
Hi Taylan,
Taylan Ulrich Kammer <taylanbayirli@gmail.com> writes:
> From 2dcd57e71c86c780e0e06ae5579c2f8e65b3de91 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Fri, 15 May 2015 10:59:44 +0200
> Subject: [PATCH] Parameterize references to /gnu/store.
>
> * gnu/packages/busybox.scm (busybox): Call %store-directory from (guix build
> utils) instead of referencing "/gnu/store" directly.
>
> * guix/packages.scm (patch-and-repack): Likewise.
> ---
> gnu/packages/busybox.scm | 5 +++--
> guix/packages.scm | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
>
> diff --git a/gnu/packages/busybox.scm b/gnu/packages/busybox.scm
> index d200cd7..13630b3 100644
> --- a/gnu/packages/busybox.scm
> +++ b/gnu/packages/busybox.scm
> @@ -53,8 +53,9 @@
>
> ;; There is no /usr/bin or /bin - replace it with /gnu/store
> (substitute* "testsuite/cpio.tests"
> - (("/usr/bin") "/gnu/store")
> - (("usr") "gnu"))
> + (("/usr/bin") (%store-directory))
> + (("usr") (car (filter (negate string-null?)
> + (string-split (%store-directory) #\/)))))
What is the rationale for replacing "usr" with "gnu" here? In the
general case where (%store-directory) might be almost anything, I fail
to see why "usr" should be replaced with the first component of
(%store-directory).
Mark
next prev parent reply other threads:[~2015-05-19 22:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 4:07 --with-store-dir and/or --localstatedir seem to be ignored Alex Vorobiev
2015-05-15 9:03 ` Taylan Ulrich Kammer
2015-05-15 10:45 ` Ludovic Courtès
2015-05-15 14:03 ` Taylan Ulrich Kammer
2015-05-15 14:35 ` Ludovic Courtès
2015-05-15 14:58 ` Taylan Ulrich Kammer
2015-05-15 16:51 ` Ludovic Courtès
2015-05-15 20:22 ` ftp " Alex Vorobiev
2015-05-16 19:42 ` Ludovic Courtès
2015-05-21 2:42 ` Alex Vorobiev
2015-05-21 8:20 ` Ludovic Courtès
2015-05-19 22:17 ` Mark H Weaver [this message]
2015-05-20 7:27 ` Taylan Ulrich Bayırlı/Kammer
2015-05-20 16:53 ` Mark H Weaver
2015-05-15 10:40 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw10mcuk.fsf@netris.org \
--to=mhw@netris.org \
--cc=alexander.vorobiev@gmail.com \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).