From: Jeff Mickey <j@codemac.net>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: add the rc shell package
Date: Sat, 11 Jul 2015 17:57:00 -0700 [thread overview]
Message-ID: <87mvz2b3c3.fsf@codemac.net> (raw)
In-Reply-To: <87d1zz5lbn.fsf@netris.org>
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
Thank you so much for the kind and prompt feedback folks!
Here is my updated patch, let me know if I've addressed your concerns.
// codemac
[-- Attachment #2: 0001-gnu-add-the-rc-shell-package.patch --]
[-- Type: text/x-patch, Size: 3748 bytes --]
From 85e9fef8f3eec0b434c909627cd68d5584597aa0 Mon Sep 17 00:00:00 2001
From: Jeff Mickey <j@codemac.net>
Date: Thu, 9 Jul 2015 17:39:42 -0700
Subject: [PATCH] gnu: add the rc shell package
* gnu/packages/rc.scm: New file.
---
gnu/packages/rc.scm | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
create mode 100644 gnu/packages/rc.scm
diff --git a/gnu/packages/rc.scm b/gnu/packages/rc.scm
new file mode 100644
index 0000000..6bd2b51
--- /dev/null
+++ b/gnu/packages/rc.scm
@@ -0,0 +1,77 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rc)
+ #:use-module (gnu packages autotools)
+ #:use-module (gnu packages perl)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages readline)
+ #:use-module (guix build gnu-build-system)
+ #:use-module (guix build utils)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix download)
+ #:use-module (guix git-download)
+ #:use-module (guix licenses)
+ #:use-module (guix packages))
+
+(define-public rc
+ (package
+ (name "rc")
+ (version "1.7.4")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "git://github.com/rakitzis/rc.git")
+ ;; commit name 'release: rc-1.7.4'
+ (commit "c884da53a7c885d46ace2b92de78946855b18e92")))
+ (sha256
+ (base32
+ "00mgzvrrh9w96xa85g4gjbsvq02f08k4jwjcdnxq7kyh5xgiw95l"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:configure-flags
+ '("--with-edit=gnu")
+ #:phases
+ (modify-phases %standard-phases
+ (add-before
+ 'configure 'autoreconf
+ (lambda _ (zero? (system* "autoreconf" "-vfi"))))
+ (add-before
+ 'autoreconf 'rewrite-paths
+ (lambda _
+ (substitute* "trip.rc"
+ (("/bin/pwd") (which "pwd"))
+ (("/bin/sh") (which "sh")))))
+ ;; this removes a single test which checks that for sure rm is in
+ ;; /bin/rm
+ (add-after
+ 'rewrite-paths 'patch-triprc
+ (lambda _ (zero? (system* "sed" "-i" "282,284d" "trip.rc")))))
+ #:tests? #t)) ;; trip.rc explicity tests for /bin
+ (inputs `(("readline" ,readline)
+ ("perl" ,perl)))
+ (native-inputs `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("libtool" ,libtool)
+ ("pkg-config" ,pkg-config)))
+ (synopsis "An alternative implementation of the plan 9 rc shell.")
+ (description
+ "This is a reimplementation for Unix, by Byron Rakitzis, of the Plan 9
+shell. It has a small feature set similar to a traditional Bourne shell.")
+ (home-page "http://github.com/rakitzis/rc")
+ (license zlib)))
--
2.4.5
next prev parent reply other threads:[~2015-07-12 0:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 1:02 [PATCH] gnu: add the rc shell package Jeff Mickey
2015-07-10 13:59 ` Ricardo Wurmus
2015-07-10 22:27 ` Jeff Mickey
2015-07-11 4:37 ` Ricardo Wurmus
2015-07-11 5:12 ` Mark H Weaver
2015-07-12 0:57 ` Jeff Mickey [this message]
2015-07-12 2:18 ` Mark H Weaver
2015-07-12 5:35 ` Jeff Mickey
2015-07-12 22:46 ` Jeff Mickey
2015-07-13 3:15 ` Mark H Weaver
2015-07-13 20:22 ` Jeff Mickey
2015-07-13 23:34 ` Mark H Weaver
2015-07-13 6:51 ` Alex Kost
2015-07-13 17:14 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvz2b3c3.fsf@codemac.net \
--to=j@codemac.net \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).