From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 07/11] gnu: ncurses: support mingw.
Date: Tue, 09 Aug 2016 10:53:27 +0300
Message-ID: <87mvkmcr9k.fsf@gmail.com>
References: <20160809064139.27872-1-janneke@gnu.org>
	<20160809064139.27872-8-janneke@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52361)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bX1qv-0004GY-Ju
	for guix-devel@gnu.org; Tue, 09 Aug 2016 03:53:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bX1qr-0007Rf-Fk
	for guix-devel@gnu.org; Tue, 09 Aug 2016 03:53:32 -0400
In-Reply-To: <20160809064139.27872-8-janneke@gnu.org> (Jan Nieuwenhuizen's
	message of "Tue, 9 Aug 2016 08:41:35 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

Jan Nieuwenhuizen (2016-08-09 09:41 +0300) wrote:

> * gnu/packages/patches/ncurses-mingw.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/ncurses.scm (ncurses): Support mingw.
[...]
>  (define-public ncurses
> @@ -36,6 +39,7 @@
>                      #:allow-other-keys)
>              (let ((out (assoc-ref outputs "out"))
>                    (doc (assoc-ref outputs "doc")))
> +              (format #t "configure flags: ~s~%" configure-flags)
>                (zero? (apply system* "./configure"
>                              (string-append "SHELL=" (which "sh"))
>                              (string-append "--build=" build)
> @@ -60,33 +64,66 @@
>                 "mandir=share/man"))
>              #t))
>          (post-install-phase
> -         '(lambda* (#:key outputs #:allow-other-keys)
> -            (let ((out (assoc-ref outputs "out")))
> +         `(lambda* (#:key outputs target #:allow-other-keys)
> +            (let ((out (assoc-ref outputs "out"))
> +                  (mingw-target? (lambda* (#:optional (target target))
> +                                   (and target
> +                                        (string-suffix? "-mingw32" target))))

IIUC you don't use the same 'mingw-target?' procedure you added in an
earlier patch, because it is placed in (guix utils), right?  I don't
know if (guix build utils) would be a better place for it, but I think
this 'mingw-target?' may be used by other packages quite often, so it
should be available by default to avoid the same definitions in other
packages.

-- 
Alex