From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add toxic (Need help with ncurses+libnotify not being found). Date: Sun, 21 Aug 2016 10:29:43 +0300 Message-ID: <87mvk67f6g.fsf@gmail.com> References: <871t1iuacb.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbNCY-0002Fo-Gb for guix-devel@gnu.org; Sun, 21 Aug 2016 03:29:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbNCT-0000tU-GD for guix-devel@gnu.org; Sun, 21 Aug 2016 03:29:49 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:34866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbNCT-0000su-8U for guix-devel@gnu.org; Sun, 21 Aug 2016 03:29:45 -0400 Received: by mail-lf0-x244.google.com with SMTP id l89so4799346lfi.2 for ; Sun, 21 Aug 2016 00:29:44 -0700 (PDT) In-Reply-To: <871t1iuacb.fsf@we.make.ritual.n0.is> (ng0@we.make.ritual.n0.is's message of "Sun, 21 Aug 2016 02:25:40 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 (2016-08-21 05:25 +0300) wrote: > There are serious cosmetic improvements I need to to make on these > patches, I am aware of this, but what I am asking help for is: > > I've tried for hours many ways to make toxic find "libnotify" and > "ncursesw" ... It does not > happen... setenv. substitute. ldflags. user_ldflags. cflags. user_cflags. nothing.. > > Can someone shed some light on this? As I see 'toxic' has a hand-written Makefile, so it probably doesn't use pkg-config properly to find "libnotify". Did you try to add "/include/libnotify" to CPATH (as it is done in 'webkitgtk' package, for example)? [...] > +(define-public libtoxcore > + (let ((revision "1") > + (commit "755f084e8720b349026c85afbad58954cb7ff1d4")) > + (package > + (name "libtoxcore") > + (version (string-append "0.0.0" "-" > + revision (string-take commit 8))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/irungentoo/toxcore.git") > + (commit commit))) > + (file-name (string-append name "-" version)) I prefer: (file-name (string-append name "-" version "-checkout")) I think it is more clean. > + (sha256 > + (base32 > + "0ap1gvlyihnfivv235dbrgsxsiiz70bhlmlr5gn1027w3h5kqz8w")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ;; TODO: Add when test suite is capable of passing. > + ;; ("check" ,check) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("libsodium" ,libsodium) > + ("opus" ,opus) > + ("libvpx" ,libvpx))) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'configure 'autoconf It should be added after 'unpack' phase, because... I forgot the reason :-) but it relates to other phases between 'unpack' and 'configure' on "arm" or "mips" systems. [...] > +(define-public toxic > + (package > + (name "toxic") > + (version "0.7.0") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/JFreegman/" > + name "/archive/v" version ".tar.gz")) > + (file-name (string-append name "-" version)) Don't forget to change it to: (file-name (string-append name "-" version ".tar.gz")) -- Alex