From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: femtolisp: Remove support for mips and armhf.
Date: Mon, 26 Sep 2016 12:38:37 +0200
Message-ID: <87mvivj68i.fsf@gnu.org>
References: <87mvjbegxs.fsf@elephly.net> <87oa3rmtg8.fsf@we.make.ritual.n0.is>
	<87d1k6etze.fsf@elephly.net> <874m5i3k0h.fsf@we.make.ritual.n0.is>
	<87y42u24nc.fsf@we.make.ritual.n0.is> <87a8faer2a.fsf@elephly.net>
	<871t0miy7t.fsf@we.make.ritual.n0.is> <877faeeo7m.fsf@elephly.net>
	<87sht2afyr.fsf@we.make.ritual.n0.is>
	<87h99ieljb.fsf@we.make.ritual.n0.is> <20160918100239.GA4752@solar>
	<87fuovp06b.fsf@gnu.org> <87mvj0z4bu.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1boYB9-0003kj-A7
	for guix-devel@gnu.org; Mon, 26 Sep 2016 11:50:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1boYB6-00058V-IB
	for guix-devel@gnu.org; Mon, 26 Sep 2016 11:50:50 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:5250)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1boYB6-00057v-84
	for guix-devel@gnu.org; Mon, 26 Sep 2016 11:50:48 -0400
In-Reply-To: <87mvj0z4bu.fsf@we.make.ritual.n0.is> (ng0's message of "Thu, 22
	Sep 2016 09:11:49 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ngillmann@runbox.com>
Cc: guix-devel@gnu.org

ng0 <ngillmann@runbox.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Andreas Enge <andreas@enge.fr> skribis:
>>
>>> femtolisp fails on mips and arm:
>>>    http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload
>>> with the message
>>> In file included from llt/llt.h:6:0,
>>>                  from string.c:16:
>>> llt/utils.h:27:4: error: #error "unknown architecture"
>>>  #  error "unknown architecture"
>>>
>>> Should it be disabled there?
>>
>> Definitely.  It would be worth checking in that file the set of
>> supported architectures, and putting them in =E2=80=98supported-platform=
s=E2=80=99.
>
> I'm not exactly sure what's supported, I found win32, osx, freebsd,
> openbsd, and that's it.

Sorry, I really meant supported architectures, which is what utils.h
seems to be about (although I don=E2=80=99t have the source here to check).
Could you check the #ifdefs in there?

> +      ;; armhf and mips64el fail to build, it has been reported upstream:
> +      ;; https://github.com/JeffBezanson/femtolisp/issues/25
> +      (supported-systems
> +       (and
> +        (delete "armhf-linux" %supported-systems)
> +        (delete "mips64el-linux" %supported-systems)
> +        #t))

=E2=80=98supported-systems=E2=80=99 must be a list of strings, so:

  (fold delete %supported-systems
        '("armhf-linux" "mips64el-linux"))

Thanks,
Ludo=E2=80=99.