From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Allan Webber Subject: Re: Cosmetical change: remove inconsistent "$file ends here"? Date: Mon, 26 Sep 2016 03:32:24 -0500 Message-ID: <87mviv12p3.fsf@dustycloud.org> References: <871t09t6f1.fsf@we.make.ritual.n0.is> <87a8ewl6tq.fsf@gmail.com> <87zimws5b1.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boRLi-0000lZ-Kc for guix-devel@gnu.org; Mon, 26 Sep 2016 04:33:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boRLe-0005ff-K8 for guix-devel@gnu.org; Mon, 26 Sep 2016 04:33:18 -0400 Received: from dustycloud.org ([50.116.34.160]:42714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boRLe-0005ay-Gu for guix-devel@gnu.org; Mon, 26 Sep 2016 04:33:14 -0400 In-reply-to: <87zimws5b1.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org, Alex Kost ng0 writes: > Alex Kost writes: > >> ng0 (2016-09-24 20:00 +0000) wrote: >> >>> We should either be consistent with this in all files or remove this >>> altogether in my opinion. >>> >>>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here" >>>> gnu/build/vm.scm:323:;;; vm.scm ends here >> ... >>> What do you think? >> >> I don't know what the original purpose of this convention is, it was >> probably invented in those ancient times when dinosaurs walked by >> streets, but I kinda like these "ends here" things :-) >> >> The only purpose I see in using them: you can be sure that there will >> not appear redundant newlines (introduced by untidy commits) in the end >> of files. >> >> Anyway, I vote for leaving them and adding the missing ones. > > Okay, with your explanation this is the more reasonable thing to do. I'm really fine either way, but that doesn't feel like a super compelling reason to me. Who cares if there's a redundant newline at the end of the file? Sure, it should be swept up, but one redundant newline costs a lot less than "don't let any newlines after this". Plus, do we have proof that no newlines will really appear afterwards? It feels like cruft that nobody knows the reason for, or has a good reason in this modern age. I'd rather they just be trimmed. But I also don't feel like it matters much, so whatever is decided is decided. :)