From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH 3/6] file-systems: Suppress fsck status completion bar.
Date: Mon, 07 Nov 2016 09:29:08 +0000
Message-ID: <87mvhb8wpn.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
References: <20161105125511.29383-1-mbakke@fastmail.com>
	<20161105125511.29383-4-mbakke@fastmail.com>
	<87r36owaap.fsf@gnu.org>
	<87y40w88g9.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
	<8760nzy8bj.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44065)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1c3gEw-00009c-Ev
	for guix-devel@gnu.org; Mon, 07 Nov 2016 04:29:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1c3gEr-0007CD-Gx
	for guix-devel@gnu.org; Mon, 07 Nov 2016 04:29:18 -0500
In-Reply-To: <8760nzy8bj.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Hey!
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>>
>>> Marius Bakke <mbakke@fastmail.com> skribis:
>>>
>>>> * gnu/build/file-systems.scm (check-file-system): Drop "-C" argument
>>>> from fsck for compatibility with other fscks.
>>>
>>> Oh so fsck.ext2 would no longer show any kind of progress report?
>>> That=E2=80=99s annoying.
>>>
>>> Could we address it differently?  Not sure how, though.
>>
>> We would have to provide a custom check-file-system procedure for each
>> detected file-system. That might be needed in the long run anyway, but I
>> think this is a worthwhile compromise for now.
>
> What about adding a one-argument procedure as the =E2=80=98check-procedur=
e=E2=80=99
> field of <file-system>, with a sane default, like:
>
>   (define (default-file-system-check file-system)
>     #~(system* (string-append "fsck." #$(file-system-type file-system))
>                =E2=80=A6))
>
> ?
>
> In fact, that would also remove the need for the special case to add
> dosfstools to the initrd because we could simply write:
>
>   (define (fat-file-system-check file-system)
>     #~(system* #$(file-append vfatfsck/static "/bin/fsck.vfat")
>                =E2=80=A6))
>
> and that would automatically bring vfatfsck/static to the initrd when
> it=E2=80=99s needed, and only then.
>
> WDYT?
>
> (Same design pattern as =E2=80=98open=E2=80=99 in <device-mapping>.)

This looks very promising. Will try to make it work -- new patches
hopefully later this week! :)


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJYIEllAAoJEKKgbfKjOlT6kVcIAL5RsfyO8XzMxpgb/BU3/127
Aj4bzjpsET5a2XlHTLVWnTeIO+tk7C9ze2RXxj6H0Pdx31caQQvC8MQnNNFgJcnh
m/sG7scAmnXBlQAnaNAcFBWXTGQFaZXAS+Os/rI62v2AXsNkdgVrZ2LUFZqhOve1
cc2e1Cvah++ro8p/u3G9MLeQddsyw7putbsYp4WfJJpNKEmNIHAbPy7RBn3GJHmZ
i0h3PvKwAjxs+EvmT/ttfByyZbi242vk2b5OfJCZB4/F2mHyBZthR6/Oprsj8GjQ
6S2NHcmLvP953WB4Ck7Hna5qKAxMyB/o3Pdgc3T696I4TLrbVvv0xCGai6zat5A=
=3nzk
-----END PGP SIGNATURE-----
--=-=-=--