From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/4] gnu: Add XFILESEARCH path to profiles' environment. Date: Tue, 29 Nov 2016 22:42:49 +0100 Message-ID: <87mvginesm.fsf@gnu.org> References: <1480100924-23868-1-git-send-email-jmd@gnu.org> <87zikkk485.fsf@gnu.org> <20161128131926.GA6466@jocasta.intra> <878ts273to.fsf@gnu.org> <20161129181559.GA30970@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBqAx-0000vj-Mn for guix-devel@gnu.org; Tue, 29 Nov 2016 16:42:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBqAu-0000ct-DH for guix-devel@gnu.org; Tue, 29 Nov 2016 16:42:55 -0500 In-Reply-To: <20161129181559.GA30970@jocasta.intra> (John Darrington's message of "Tue, 29 Nov 2016 19:16:00 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org John Darrington skribis: > On Tue, Nov 29, 2016 at 03:34:11PM +0100, Ludovic Court??s wrote: > John Darrington skribis: > > > We can cut down on the size of this string iff we can somehow > > guarantee that no package ever ships a file in any of those locati= ons. > > > > Some "solutions" (in my order of preference) are: > > > > * The size of the above list can be halved, by dropping either the > > .../lib/... or the .../share/... items - we just have to then make > > sure that no package ships resource files in the one we drop. His= torically, > > resource files were always in .../lib (as still are all official > > sources from x.org) but recently third party packages have started > > putting them in .../share. > > > > * I *think* we could also get away with further reducing the set t= o=20 > > "$HOME/.guix-profile/lib/X11/%T/%N%S: > > /run/current-system/profile/lib/X11/%T/%N%S" > > because, all the Xt dependent packages I've seen so far, put their > > resource files there. However, we cannot know what might get added > > in the future. >=20=20=20=20=20=20 > Right, if we do both, that???s already much better. >=20=20=20=20=20=20 > > * Hack the hard coded defaults in the libXt source to use the prof= ile > > settings instead of /usr >=20=20=20=20=20=20 > Maybe we should just do that, no? It???d be a local change, it would > achieve the same effect, and it would provide a good default. >=20=20=20=20=20=20 > WDYT? > > It sounds unreliable to me. What would we set it to? > $GUIX_PROFILE/... $HOME/.guix-profile/... /run/current-system/profile/... > There's no guarantee that the current profile is any of those. Maybe, but that would have the same effect as setting the environment variable to that value, wouldn=E2=80=99t it? > Something similar to the first solution seems prefereable to me. Maybe: > > Set XFILESEARCHPATH to "$HOME/.guix-profile/lib/X11/%T/%N%S:/run/current= -system/profile/lib/X11/%T/%N%S" > (we can substitute "share" for "lib" if we want to keep the FHS people = happy). How did you manage to shorten it that much? It=E2=80=99s much less intimid= ating now. :-) > Then we audit all users of libxt to make sure they put their resource fi= les in lib/X11/app-defaults. > Most packages have a --with-app-defaults configure option (which current= ly we are in many cases > either not using or misusing). > > We could also consider adding a build stage to make sure that packages w= hich depend on libXt put > their resource files in the "right" place. Sounds reasonable. Ludo=E2=80=99.