From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 04/12] import: Add importer for rust crates.
Date: Tue, 13 Dec 2016 18:30:16 +0100
Message-ID: <87mvfzrb2v.fsf@gnu.org>
References: <20161211172537.23315-1-david@craven.ch>
	<20161211172537.23315-5-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cGquE-00029s-EH
	for guix-devel@gnu.org; Tue, 13 Dec 2016 12:30:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cGquA-00043p-JN
	for guix-devel@gnu.org; Tue, 13 Dec 2016 12:30:22 -0500
In-Reply-To: <20161211172537.23315-5-david@craven.ch> (David Craven's message
	of "Sun, 11 Dec 2016 18:25:29 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * guix/import/crate.scm: New file.
> * guix/scripts/import/crate.scm: New file.
> * guix/scripts/import.scm (importers): Add crate importer.
> * tests/crate.scm: New file.
> * doc/guix.texi: Add crate importer to table.

Please add the new files in Makefile.am, local.mk, etc.

Other than that LGTM, thanks!

Ludo=E2=80=99.