From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 3/3] gnu: Add paprefs Date: Tue, 20 Dec 2016 15:35:07 +0000 Message-ID: <87mvfqwr4k.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> References: <1455721361-14591-1-git-send-email-mail@cbaines.net> <1455721361-14591-4-git-send-email-mail@cbaines.net> <20160220053931.GC10772@jasmine> <87oa37cb1d.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJMSH-0000Xi-4U for guix-devel@gnu.org; Tue, 20 Dec 2016 10:35:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJMSA-00040t-Ph for guix-devel@gnu.org; Tue, 20 Dec 2016 10:35:53 -0500 Received: from aibo.runbox.com ([91.220.196.211]:41249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cJMSA-0003yz-Iw for guix-devel@gnu.org; Tue, 20 Dec 2016 10:35:46 -0500 In-Reply-To: <87oa37cb1d.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , Christopher Baines Cc: guix-devel@gnu.org ng0 writes: > I found neither paprefs nor gconfmm in our package database as I was > about to move this to my 'done' tag, out of sight. > Can someone (Christopher? Leo?) finish this? As I got no reply after my initial question, I will fix both of these packages up next month. > Thanks. > Leo Famulari writes: > >> On Wed, Feb 17, 2016 at 03:02:41PM +0000, Christopher Baines wrote: >>> * gnu/packages/pulseaudio.scm (paprefs): New variable >> >> Cool, thanks for the patches! This review is rather superficial since I >> don't have a GuixSD desktop system, so I can't really test the >> functionality of the software provided by this patch series. I assume it >> works for you. Did you test it on GuixSD or on a foreign distro? >> >>> --- >>> gnu/packages/pulseaudio.scm | 34 ++++++++++++++++++++++++++++++++++ >>> 1 file changed, 34 insertions(+) >> >> [...] >> >>> +(define-public paprefs >>> + (package >>> + (name "paprefs") >>> + (version "0.9.10") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append >>> + "https://freedesktop.org/software/pulseaudio/paprefs/paprefs-" >>> + version >>> + ".tar.xz")) >> >> I'd prefer if the URL started directly after string-append, and then >> used the minimum number of lines, while staying within the 80 character >> limit. I can correct this sort of thing when applying patches, but I >> must say it out loud once in a while ;) >> >>> + (sha256 >>> + (base32 >>> + "1c5b3sb881szavly220q31g7rvpn94wr7ywlk00hqb9zaikml716")))) >>> + (build-system gnu-build-system) >>> + (arguments >>> + '(#:configure-flags '("CXXFLAGS=-std=c++11"))) ; required by gtkmm >>> + (inputs >>> + `(("pulseaudio" ,pulseaudio) >>> + ("gconfmm" ,gconfmm) >>> + ("lynx" ,lynx) ; used for documentation generation >> >> If it's only used to generate the docs, can we make it a native-input, >> so it's only available while building? >> >>> + ("libglademm" ,libglademm) >>> + ("dbus-glib" ,dbus-glib))) >>> + (native-inputs >>> + `(("intltool" ,intltool) >>> + ("pkg-config" ,pkg-config))) >>> + (home-page "https://freedesktop.org/software/pulseaudio/paprefs/") >>> + (synopsis "simple configuration dialog for PulseAudio") >> >> The linter whines that the synopsis does not start with a capital >> letter. What, you don't like the linter? ;) >> >>> + (description >>> + "PulseAudio Preferences (paprefs) is a simple GTK+ based configuration >>> +dialog for the PulseAudio sound server.") >>> + (license l:gpl2+))) >>> -- >>> 2.7.0 >>> >>> >> > > -- > ng0 > > -- ♥Ⓐ ng0 | PGP keys and more: https://n0is.noblogs.org/ | http://ng0.chaosnet.org