From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] gnu: Add python-pyodbc-c. Date: Thu, 26 Jan 2017 16:55:11 +0000 Message-ID: <87mvedkbgw.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> References: <20170126002621.9247-1-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWnJE-0005b9-Lk for guix-devel@gnu.org; Thu, 26 Jan 2017 11:54:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWnJ9-0007Os-Pz for guix-devel@gnu.org; Thu, 26 Jan 2017 11:54:04 -0500 Received: from perdizione.investici.org ([2001:41d0:2:33d0::19]:45327) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWnJ8-0007OO-Gi for guix-devel@gnu.org; Thu, 26 Jan 2017 11:53:59 -0500 In-Reply-To: <20170126002621.9247-1-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org Danny Milosavljevic writes: > * gnu/packages/databases.scm (python-pyodbc-c, python2-pyodbc-c): > New variables. > --- > gnu/packages/databases.scm | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm > index e8be17980..fc576888d 100644 > --- a/gnu/packages/databases.scm > +++ b/gnu/packages/databases.scm > @@ -1312,3 +1312,29 @@ development.") > ;; test/crypto.test are licensed under a 3-clause BSD license. All= other > ;; source files are in the public domain. > (license (list license:public-domain license:bsd-3)))) > + > +(define-public python-pyodbc-c > + (package > + (name "python-pyodbc-c") > + (version "3.1.2") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://gitlab.com/daym/pyodbc-c/repositor= y/" > + "archive.tar.gz?ref=3Dv" version)) > + (sha256 > + (base32 "0nl11n3mgrcfnhimjqgv48rxqnb21l5m6s7p8ps2fa4nn4z6rzy0"= )) I would put this as (sha256 (base32 "")) but I guess this works too as long as lint is happy. > + (file-name (string-append name "-" version ".tar.gz")))) > + (build-system python-build-system) > + (inputs > + `(("unixodbc" ,unixodbc))) > + (arguments > + `(#:tests? #f ; no tests exist > + )) > + (home-page "https://github.com/mkleehammer/pyodbc") This is pulled from gitlab and the homepage is on gitlab? I think it's better to use the gitlab repository as home-page then, or what's the reason? > + (synopsis "Python ODBC Library") > + (description "This package provides a Python DB-API driver for ODB= C.") If I remember correctly, we should avoid starting synopsis and description with words like "This". What about: (description "@code{python-pyodbc-c} provides =E2=80=A6" > + (license (license:x11-style "file://LICENSE.TXT")))) > + > +(define-public python2-pyodbc-c > + (package-with-python2 python-pyodbc-c)) > Besides those small comments it looks good to me! --=20 =E2=99=A5=E2=92=B6 ng0 -- https://www.inventati.org/patternsinthechaos/