From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: core-updates: Fix cups-minimal build failure Date: Sun, 26 Feb 2017 15:45:18 +0100 Message-ID: <87mvd9f1tt.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170226022519.GA16840@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ci04k-0006om-Sb for guix-devel@gnu.org; Sun, 26 Feb 2017 09:45:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ci04h-0002Xu-Pj for guix-devel@gnu.org; Sun, 26 Feb 2017 09:45:26 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43513) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ci04h-0002X5-LK for guix-devel@gnu.org; Sun, 26 Feb 2017 09:45:23 -0500 In-Reply-To: <20170226022519.GA16840@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > Do you have any suggestions about how to make this more concise? > From 0191e8394eedd271494b5e1e8c8eb131176440a8 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Sat, 25 Feb 2017 21:22:08 -0500 > Subject: [PATCH] gnu: cups-minimal: Fix build failure in reset-gzip-times= tamps > phase. > > * gnu/packages/cups.scm (cups-minimal)[arguments]: Add 'make-manpages-wri= table' > phase. > --- > gnu/packages/cups.scm | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm > index 20621e32b..ebb979c62 100644 > --- a/gnu/packages/cups.scm > +++ b/gnu/packages/cups.scm > @@ -166,6 +166,23 @@ filters for the PDF-centric printing workflow introd= uced by OpenPrinting.") > (substitute* "Makedefs.in" > (("INITDIR.*=3D.*@INITDIR@") "INITDIR =3D @prefix@/@INITD= IR@") > (("/bin/sh") (which "sh"))))) > + ;; Make the compressed manpages writable so that the > + ;; reset-gzip-timestamps phase does not error out. > + (add-before 'reset-gzip-timestamps 'make-manpages-writable > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (man1 (string-append out "/share/man/man1")) > + (man5 (string-append out "/share/man/man5")) > + (man7 (string-append out "/share/man/man7")) > + (man8 (string-append out "/share/man/man8"))) > + (for-each (lambda (file) (chmod file #o666)) > + (find-files man1 "\\.gz")) > + (for-each (lambda (file) (chmod file #o666)) > + (find-files man5 "\\.gz")) > + (for-each (lambda (file) (chmod file #o666)) > + (find-files man7 "\\.gz")) > + (for-each (lambda (file) (chmod file #o666)) > + (find-files man8 "\\.gz"))))) Would it work to simply run this on all of "out/share/man", instead of explicitly specifying the sections? I would also use 0644 perms here, not that it matters though! > (add-before 'build 'patch-tests > (lambda _ > (substitute* "test/ippserver.c" > --=20 > 2.11.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliy6f4ACgkQoqBt8qM6 VPqRbQgApYvrQq2nl6Wmep0krPru84FcpIWZVuDJR2R+UPnY+OhO2XDkHud2gYlO BYX/Lz4pxUBo0XMdvErzZAQtkxCC+50ce0ySYKdqeN4j+4uk7zwqW87bigGf9nuB d6oe5OsEWqQS1qUByuThPhcTi2sHSGe/Crj87I88UVtAOvJRXeXiTHQOshbspMgm i4ksbP8pQnKKnFNge0So1RA9ve4O2i6x31SKy0rz7+YDpP5x76F+kuXrNS1YBm/3 HZuYFYPBrtDkG00I+YvXASAovRt21IvWmJsgATv8FUZtOZkiavWeFTl8esUCy3hn aFm5Lqs1LcXechZXg1qdJGQ3q61aKw== =D/IR -----END PGP SIGNATURE----- --=-=-=--