From: "Huang\, Ying" <huang_ying_caritas@163.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Could anyone help me to pack the shellcheck (haskell)
Date: Sun, 12 Mar 2017 16:03:22 +0800 [thread overview]
Message-ID: <87mvcqx6ph.fsf@163.com> (raw)
In-Reply-To: <20170309193441.494c63b6@scratchpost.org> (Danny Milosavljevic's message of "Thu, 9 Mar 2017 19:34:41 +0100")
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi,
>
> On Thu, 09 Mar 2017 19:39:19 +0800
> "Huang\, Ying" <huang_ying_caritas@163.com> wrote:
>
>> Danny Milosavljevic <dannym@scratchpost.org> writes:
>>
>> > Hi,
>> >
>> > On Wed, 08 Mar 2017 20:08:41 +0800
>> > "Huang\, Ying" <huang_ying_caritas@163.com> wrote:
>> >
>> >> I know very little about Haskell, but I use shellcheck
>> >> (https://github.com/koalaman/shellcheck) to check my shell scripts. I
>> >> tried myself, but found it is hard for me. Could anyone help me on
>> >> that?
>>
>> Great! It works!
>
> Nice. Good to know that it works for you as-is.
>
>>Thanks a lot! Now I can use shellcheck. Could you
>> make it merged by Guix?
>
> Eventually, but it has to go through the normal review process in any case.
>
> Could you give some details for the description? I'm not a user of shellcheck so I have no idea what else to put there.
Copied from the README of the shellcheck, I think this is a more
detailed description.
ShellCheck is a GPLv3 tool that gives warnings and suggestions for
bash/sh shell scripts. The goals of ShellCheck are,
- To point out and clarify typical beginner's syntax issues that cause
a shell to give cryptic error messages.
- To point out and clarify typical intermediate level semantic problems
that cause a shell to behave strangely and counter-intuitively.
- To point out subtle caveats, corner cases and pitfalls that may cause an
advanced user's otherwise working script to fail under future circumstances.
> Also, could you do a license review (check the shellcheck source files for header comments which say what license to use) and make sure it's actually gpl3 or later ?
Check all *.hs files in the shellcheck. All files except
ShellCheck/Data.hs has header comments which say gpl3 or later is used.
The ShellCheck/Data.hs has no header comments about copyright and there
are only several variable definitions in the file.
Best Regards,
Huang, Ying
> Then I'll post an updated patch to guix-patches (to be merged eventually after review) if you want.
prev parent reply other threads:[~2017-03-12 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 12:08 Could anyone help me to pack the shellcheck (haskell) Huang, Ying
2017-03-08 21:04 ` Danny Milosavljevic
2017-03-09 11:39 ` Huang, Ying
2017-03-09 18:34 ` Danny Milosavljevic
2017-03-11 0:28 ` Huang, Ying
2017-03-12 8:03 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvcqx6ph.fsf@163.com \
--to=huang_ying_caritas@163.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).