From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: GSoC-2018 - Build daemon rewrite in Scheme Updates Date: Tue, 29 May 2018 21:52:27 +0200 Message-ID: <87muwitf2c.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNkfW-0003zB-T1 for guix-devel@gnu.org; Tue, 29 May 2018 15:52:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNkfV-0007bi-Rx for guix-devel@gnu.org; Tue, 29 May 2018 15:52:31 -0400 In-Reply-To: (Sandeep Subramanian's message of "Tue, 29 May 2018 11:50:45 +0530") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Sandeep Subramanian Cc: guix-devel@gnu.org Hello uniq10, Thanks for the update! Sandeep Subramanian skribis: > `build-derivation` is now using `call-with-container` > and it seems to work well. `build-derivation` assumes > that all the inputs needed for the derivation is already > built and ready. As a next step I wanted to try and build > the `inputDrvs` if the inputs are missing. Nice, it sounds like a good start. Where is the code you=E2=80=99ve been working on? Is it ? In general, I would encourage you to follow the project=E2=80=99s conventio= ns as closely as possible to ease future merges. See . Please also consider showing up on #guix on IRC to share what you=E2=80=99r= e up to and ask for advice whenever you feel like it. Communication is key is a distributed project like this. As discussed off-list, I just started merging into =E2=80=98master=E2=80=99= proper work from last year: . This is an area where we=E2=80=99ll obviously have to coordinate. For example it=E2=80=99d be gr= eat if you could rebase onto master once 31618 has been merged, and let me know if anything is amiss. > I looked through the C++ code to find out how exactly > this is done and I have a good understanding of it now. > I plan to emulate the behaviour of the C++ code for > the entire derivation building pipeline. > > I spent a lot of time browsing the C++ code base and had > to keep going back to it often, since I had trouble keeping > the C++ code flow in memory. So, I thought it would be > worthwhile to write some detailed notes on the C++ daemon > code base that I can refer to while coding. The notes I made > can be found here: > https://github.com/uniq10/gsoc-guix-notes/blob/master/daemon-notes.md Woow, very nice! From a quick look it does seem to correctly reflect what=E2=80=99s happening in that code. It would have helped me a lot to ha= ve such a document back then. ;-) BTW, note that you shouldn=E2=80=99t take the structure of the C++ code as a reference to follow. In Scheme we would more naturally use different idioms than those of this code (object-oriented C++). You=E2=80=99re welco= me to discuss on this list or on IRC how to structure things. Thanks for the update and for the nice work! Ludo=E2=80=99.