From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: hg-fetch with subrepos
Date: Sun, 02 Dec 2018 14:58:52 +0100
Message-ID: <87mupoowrn.fsf@gnu.org>
References: <72DC8AB8-2987-4EEB-BB69-4FCEF0B1D496@asu.edu>
	<20181202115355.51c943b5@alma-ubu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gTSGt-0007Rx-J8
	for guix-devel@gnu.org; Sun, 02 Dec 2018 08:58:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gTSGs-0002Iq-Ms
	for guix-devel@gnu.org; Sun, 02 Dec 2018 08:58:55 -0500
In-Reply-To: <20181202115355.51c943b5@alma-ubu> (=?utf-8?Q?=22Bj=C3=B6rn?=
	=?utf-8?Q?_H=C3=B6fling=22's?= message of
	"Sun, 2 Dec 2018 11:53:55 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= <bjoern.hoefling@bjoernhoefling.de>
Cc: guix-devel@gnu.org

Hello,

Bj=C3=B6rn H=C3=B6fling <bjoern.hoefling@bjoernhoefling.de> skribis:

> And I stumbled upon that problem too. Ludovic explained me on IRC: The
> problem is the metadata directory ".hg": It contains metadata that is
> not fixed. For normal hg-repositories, it will be stripped away, but
> not recursively for those with sub-repos.
>
> I have a patch that works. I just wasn't sure if it goes to master or
> to staging, as it could affect the java-packages as well.

Such a patch can go to =E2=80=98master=E2=80=99: it won=E2=80=99t trigger a=
ny rebuild because,
by definition, the content hash of an =E2=80=98origin=E2=80=99 is known in =
advance
(these are =E2=80=9Cfixed-output derivations.=E2=80=9D)

However, we should audit current uses of =E2=80=98hg-fetch=E2=80=99 with re=
cursive
sub-repos because there hashes are most likely wrong already.

> I'm attaching what I have here, will prepare an official patch tonight
> or tomorrow.

Awesome.  FWIW this patch already LGTM.  :-)

Thanks,
Ludo=E2=80=99.