From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Sample Subject: Re: Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Date: Tue, 06 Aug 2019 00:29:26 -0400 Message-ID: <87mugmq5ll.fsf@ngyro.com> References: <87muh2ckdn.fsf@ngyro.com> <21D6742C-75C4-47A0-9F1A-0C911C24E3DA@vllmrt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:39809) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hur6J-0007h9-Qs for guix-devel@gnu.org; Tue, 06 Aug 2019 00:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hur6I-0005Gx-QA for guix-devel@gnu.org; Tue, 06 Aug 2019 00:29:31 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37223) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hur6I-0005Gg-In for guix-devel@gnu.org; Tue, 06 Aug 2019 00:29:30 -0400 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Robert Vollmert Cc: guix-devel@gnu.org, 36807@debbugs.gnu.org Hi Robert, Robert Vollmert writes: > Hi all, Timothy, > > On 25. Jul 2019, at 15:29, Timothy Sample wrote: >> Other than that, LGTM. Thanks! (Do you have commit access now or >> should I push these?) > > I do have commit access now, but for the moment I=E2=80=99m keeping to the > branch wip-haskell-updates. OK. I thought that might be the case. Thanks for letting me know. > Thus, I=E2=80=99d ask you (or someone) to merge that (or the parts you de= em > appropriate). Cool! I=E2=80=99m in the process of looking everything over. In the meant= ime, I have some early questions and comments. > I=E2=80=99ve incorporated your comments, and removed > ghc-packedstring. In addition, the branch incorporates some other > patchsets: > > #36493: updating GHC-included haskell dependencies (this one is already > in core-updates) I think it makes sense to wait for the core-updates merge (which shouldn=E2=80=99t be too far out). > #36562: downgrade ansi-terminal to be compatible with the package set I=E2=80=99ve reordered these changes a bit, and they are now ready to go. > #36663: adding elm compiler dependencies (just a few extra ghc > packages) These commits seem to be in the wrong order. I think I can untangle them, though. > #36692: GHC version 8.6.5 (just as a package for now, not used to build > anything) I made some bigger changes here. Mostly, I made use of =E2=80=9Csubstitute-keyword-arguments=E2=80=9D to reuse more code from =E2= =80=9Cghc-8.4=E2=80=9D. Why do you use =E2=80=9Cpatch=E2=80=9D instead of =E2=80=9Csubstitute*=E2= =80=9D to disable the failing tests? I see from your previous patches that you used to do it with =E2=80=9Csubstitute*=E2=80=9D. > #36807: this bug report, removing three deprecated packages Since we already had a back-and-forth for these, they=E2=80=99re almost certainly fine. > no ticket: Skip tests for three Haskell packages that fail on i686 only > (and seem harmless): ghc-trifecta, ghc-yaml, ghc-libmpd-haskell. This seems reasonable to me, though I suppose it would be better to only skip them when building for i686. It looks like we only do this rarely (e.g., the =E2=80=9Cicu4c=E2=80=9D package), so maybe it=E2=80=99s n= ot a big deal. Is there any more info about =E2=80=9Cghc-trifecta=E2=80=9D? The other two= have nice comments that tell me that upstream is aware of the problem, and that it might be fixed in the future. Thanks for putting this branch together! -- Tim