From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: Erroneous uses of regex in the invokation of FIND-FILES Date: Thu, 22 Aug 2019 16:49:21 -0400 Message-ID: <87mug1ylg3.fsf@netris.org> References: <864l29iki4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:33251) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0u27-0006eB-3W for guix-devel@gnu.org; Thu, 22 Aug 2019 16:50:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0u26-0001UI-4b for guix-devel@gnu.org; Thu, 22 Aug 2019 16:50:11 -0400 Received: from world.peace.net ([64.112.178.59]:40658) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0u26-0001Oi-1w for guix-devel@gnu.org; Thu, 22 Aug 2019 16:50:10 -0400 In-Reply-To: <864l29iki4.fsf@gmail.com> (Alex Vong's message of "Thu, 22 Aug 2019 18:04:35 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Vong Cc: guix-devel@gnu.org Hi Alex, Alex Vong writes: > I find out that there are a lof of erroneous uses of regex in the > invokation of FIND-FILES. The correct usage should be: > > (find-files "." "\\.c$") > > Instead people write: > > (find-files "." ".*\\.c") > > which match unwanted files. > > For examples, in the procedure CUSTOM-GCC, the correct regex should be: > > "(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)$" > > instead of: > > ".*(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)" > > Please correct me if I am wrong. You're right. It would be good to fix these problems incrementally, as long as the changes don't cause too many rebuilds. Changes to core packages will need to wait for now, since 'core-updates' is frozen, and 'core-updates-next' should also be considered frozen, since it will become 'core-updates' as soon as Berlin has built it out a bit more. (The only change in 'core-updates-next' relative to 'core-updates' is that the new bootstrap tarballs have been fixed to be deterministic.) For some of these fixes, it might be best to apply them to 'staging'. > Right now, the erroneous use of regex in CUSTOM-GCC casues the 'bin/' > directory of the output of gccgo, gcc-objc and gcc-objc++ to be empty. I'm uncertain how many rebuilds it would trigger to change 'custom-gcc', and I don't have confidence that "guix refresh -l" is capable of giving us a reliable answer. In the meantime, would you like to file a bug report for this, so it's not forgotten? Thanks for looking into it. Best, Mark