From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: SSHv2 doesn't actually have compression levels
Date: Thu, 22 Aug 2019 23:48:50 +0200 [thread overview]
Message-ID: <87mug0j2gt.fsf@gnu.org> (raw)
In-Reply-To: <87ef28fflj.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 30 Jul 2019 03:58:32 +0200")
Hello,
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> While reading (guix scripts offload) in a (failed) attempt to get
> offloading working, the following comment caught my eye:
>
> ;; We rely on protocol-level compression from libssh to optimize
> large data
> ;; transfers. Warn if it's missing.
>
> which means that we're not currently doing our own compression inside
> the tunnel.
>
> This is significant, because it means that the COMPRESS-LEVEL field of
> BUILD-MACHINE is completely bogus[0], and probably always was - unless
[...]
> [0]: Take a look at OpenSSH's readconf.c, packet.c, and all calls to
> start_compression_out().
I don’t get it: the ‘compression-level’ field defaults to 3, and OpenSSH
does:
static int
start_compression_out(struct ssh *ssh, int level)
{
if (level < 1 || level > 9)
return SSH_ERR_INVALID_ARGUMENT;
debug("Enabling compression at level %d.", level);
[...]
}
What’s wrong?
Ludo’.
next prev parent reply other threads:[~2019-08-22 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 1:58 SSHv2 doesn't actually have compression levels Tobias Geerinckx-Rice
2019-08-22 21:48 ` Ludovic Courtès [this message]
2019-08-22 22:00 ` Tobias Geerinckx-Rice
2019-08-23 12:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mug0j2gt.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).