From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mKcrHKO4vl59RQAA0tVLHw (envelope-from ) for ; Fri, 15 May 2020 15:43:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MEoJGKO4vl6MOQAAB5/wlQ (envelope-from ) for ; Fri, 15 May 2020 15:43:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C580E940415 for ; Fri, 15 May 2020 15:43:30 +0000 (UTC) Received: from localhost ([::1]:49232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZcUj-0000jD-Qh for larch@yhetil.org; Fri, 15 May 2020 11:43:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZcUb-0000j3-FA for guix-devel@gnu.org; Fri, 15 May 2020 11:43:21 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZcUZ-0002jL-Ku for guix-devel@gnu.org; Fri, 15 May 2020 11:43:21 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1589557396; cv=none; d=zohomail.com; s=zohoarc; b=hQYCWJfJIdH6i8ZkUQYxxsGY7xAgn0Ewp/r09CBAXSV/LW/ICWjBUqtLwkvZW05AHFllgbvgIbebK/6VLnO0yGLdrzXXUARgH7cWjksXSMvyEgIYYIvpucMIknh10vpA7UkNGEK6JV8BlXvggSE3dvCfwr57yZx3PwQwcQYfZes= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589557396; h=Content-Type:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=25S5au2hLGaLr4PxDCTSiZAI8p3gNrDScJSZsaeg5n4=; b=aLNsazyvlpSRR9lKYJiEcRwXPVbrAq6QiVi8eQ8o5JHZJ8Wc81cwWacY0yYWXczovL3KE6QJosknb76TizTPi7DbPg28O4CJgxNRdkeLQ8TBY2CNoyT+120SHA0jgLS01bHc+/Nq4kj/bMwv8U8Nz5UROAbSTcWxbgBxZiwTf3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=beaver-labs.com; spf=pass smtp.mailfrom=edk@beaver-labs.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1589557396; s=zoho; d=beaver-labs.com; i=edk@beaver-labs.com; h=References:From:To:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type; bh=25S5au2hLGaLr4PxDCTSiZAI8p3gNrDScJSZsaeg5n4=; b=S/IQMtOJqP5bS3CWnkFmWMPjnYLGUqZser0+aqy8ImX+SspsmbESZ4xN2izEtkCY zxI90dxPLahOtjjdJ1u6YND2hqTVn/U87E/NdAHDcTWfajG/b81zsmlGD4O52GY4+g3 RViS5SIIZxgns8DN2C3RtYoFvkKSTysFudEx8blI= Received: from alice.lan (lfbn-idf1-1-1299-119.w90-79.abo.wanadoo.fr [90.79.23.119]) by mx.zohomail.com with SMTPS id 1589557394164856.5332593035414; Fri, 15 May 2020 08:43:14 -0700 (PDT) References: <87v9kx7jh5.fsf@alice.lan> User-agent: mu4e 1.4.4; emacs 26.3 From: Edouard Klein To: guix-devel Subject: Re: What to do when udpating a package ? In-reply-to: Message-ID: <87mu696w6w.fsf@alice.lan> Date: Fri, 15 May 2020 17:43:03 +0200 MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.11; envelope-from=edk@beaver-labs.com; helo=sender4-op-o11.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 11:32:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=beaver-labs.com header.s=zoho header.b=S/IQMtOJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: fUiQb+aBVnQc zimoun writes: > Dear Edouard, > > In complement to what Julien said. :-) > > > On Fri, 15 May 2020 at 13:36, Edouard Klein wrote: > >> - Some packages would not build, for reasons unrelated to the update of >> python-prompt-toolkit. Namely: >> - fdroidserver@1.1.1 will not build because of a failure of >> python-apache-libcloud@2.4.0 >> - python-matplotlib-documentation@3.1.2 and >> python-ipython-documentation@7.9.0 will not build because of a failure >> of texlive-union-51265 >> - python-rpy2@3.0.4-1.19868a8 would not build >> All those failure also happen on origin/master on my machine, and are >> therefore unrelated to the changes I made. >> --> Is any failure to build expected on origin/master ? > > No, it is not expected. > As Forrest Gump says: "It happens, sometimes." :-) > I was worried I had misconfigured my local version of guix. > >> --> If so, where can I check the official build success/fail status of >> a package ? > > Well, the link is ci.guix.gnu.org then top right, for example the query: > > spec:guix-master system:x86_64-linux python-apache-libcloud > > But personally I do not always understand what Cuirass reports. > Therefore, I prefer to use data.guix.gnu.org then for example: > > http://data.guix.gnu.org/repository/1/branch/master/package/fdroidserver/output-history > > I do not know the correct way to reach this webpage so I type directly > the URL -- well to be exact, I have an Emacs interactive function so I > type M-x my/guix-data fdroidserver RET and it opens the above webpage. > > Then I click to one "Failed dependency" and I arrive to: > > http://data.guix.gnu.org/build-server/1/build?derivation_file_name=/gnu/store/ccrk10g4vpzf6nk7x8j1a36s0b4z0w2l-fdroidserver-1.1.1.drv > > and I can click to the failing derivation and then I arrive to > ci.guix.gnu.org and I can give a look to the raw log. > I could not find the link to the raw log, but having access to the "official" build status is a huge relief, as I can stop worrying that the build failure is my fault. This is exactly what I was looking for. Thank you ! > > Well, I do not know if it is the correct way, but it is how I am doing > time to time to see what happens on the build farm. Be careful of > your current Guix version and the Guix version on ci you are > examining. > > >> --> If not, how can I check that my master version of guix is correct >> and is building everything it should build ? > > I do not understand what you mean. > "guix weather" to see if the substitute is available. > "guix challenge" to compare your own builds to the builds on substitutes. > > I was asking how to make sure that my local guix is OK (I had trouble getting it to work). >> --> In any case, how can I check that my change does not negatively >> affect these packages ? > > Which packages? The ones which do not currently build? Yeah, I'm worried maybe once the current build failure cause is addressed, my change will prevent them from building. > > >> - Some of the failing-in-master packages do not depend directly on >> python-prompt toolkit, but they depend on a package that depends on >> etc. >> e.g. fdroidserver@1.1.1 depends on python-androguard@3.2.1 which >> depends on python-ipython@7.9.0. >> --> fdroidserver@1.1.1 fails to build for reasons unrelated to >> python-prompt-toolkit, but both python-androguard@3.2.1 and >> python-ipython@7.9.0. both build with the new version of >> python-prompt-toolkit. Would I be correct in assuming that >> frdoidserver would build with the new version ? I assume not, but I >> would like to be sure > > I miss something about what depends on what. :-) > I do not have really the graph under my eyes. ;-) > > >> - python-iml@0.6.2 does not build with prompt-toolkit in version 3 (the >> version is explicitly stated as >=2.0 and <2.1 in the Python files), but >> when I add prompt-toolkit-2 to its propagated-inputs, it does. >> Given that python-ipython has prompt-toolkit (implicitly in version >> 3) installed in its propagated inputs, this means that any environment >> with python-iml will have prompt-toolkit in both its version 2 and 3 >> installed at the same time. I feel uneasy about this. >> --> Is this a problem ? >> --> Should I just trust that if it builds, then everything is >> allright ? > > No, it should pass the tests too. If there is tests. :-) > If not, you should install it locally and try it. Yeah, installing does not work :D See my answer to Julien > Because the package could build but should have runtime issues. > > >> --> Is there a way to check the graph to make the edges as >> sparse as possible (i.e. remove as many edges as possible without >> changing the reachability) ? Would this be something we want ? >> According to me it would because it would make the packages >> definitions shorter and the computations on the graph faster, but I'm >> not sure. > > What do you mean by "reachability"? > There is a new feature to "guix graph": '--path'. You can find the > shortest path from one package to another, e.g., > > guix graph --path guix-jupyter python > > What do you mean by "the edges as sparse as possible"? > > So if A depends on B and C, and B also depends on C, which is preferable as far as explicit input declarations in the packages code go: -- A->B; B->C; -- or A->B; A->C; B->C; -- The reachability (in the graph theoretical sense https://en.wikipedia.org/wiki/Reachability) is the same, but one graph has one edge less and is thus "minimal". If I understood Julien correctly he seems to think that the fully connected case is better (easier maintainability). > > All the best, > simon Thank you for your time, Cheers, Edouard.