From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id bDwgJPkN1l60RAAA0tVLHw (envelope-from ) for ; Tue, 02 Jun 2020 08:29:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KL+jH/kN1l7ecAAA1q6Kng (envelope-from ) for ; Tue, 02 Jun 2020 08:29:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E2FD94050A for ; Tue, 2 Jun 2020 08:29:44 +0000 (UTC) Received: from localhost ([::1]:47548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg2Ip-0004rz-He for larch@yhetil.org; Tue, 02 Jun 2020 04:29:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg2Ih-0004rX-Ut for guix-devel@gnu.org; Tue, 02 Jun 2020 04:29:35 -0400 Received: from mira.cbaines.net ([212.71.252.8]:52206) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg2Ih-0001S5-2C for guix-devel@gnu.org; Tue, 02 Jun 2020 04:29:35 -0400 Received: from localhost (unknown [46.237.173.126]) by mira.cbaines.net (Postfix) with ESMTPSA id 3F75127BBE1; Tue, 2 Jun 2020 09:29:34 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b8358dc5; Tue, 2 Jun 2020 08:29:31 +0000 (UTC) References: <20200601191735.15328.13392@vcs0.savannah.gnu.org> <20200601191737.45A2520A26@vcs0.savannah.gnu.org> <87o8q150wx.fsf@cbaines.net> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Paul Garlick Subject: Re: 01/03: gnu: ikiwiki: Revert to standard wrapper. In-reply-to: <87o8q150wx.fsf@cbaines.net> Date: Tue, 02 Jun 2020 09:29:31 +0100 Message-ID: <87mu5l50r8.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/02 04:29:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: l5K6vsX+uu2c --=-=-= Content-Type: text/plain Christopher Baines writes: > guix-commits@gnu.org writes: > >> pgarlick pushed a commit to branch master >> in repository guix. >> >> commit a0362fdea9369b7927704e48cfc6c578213019ce >> Author: Paul Garlick >> AuthorDate: Thu May 28 10:34:40 2020 +0100 >> >> gnu: ikiwiki: Revert to standard wrapper. >> >> * gnu/packages/web.scm (ikiwiki)[arguments]: Remove >> unnecessary 'include-PERL5LIB-in-wrapper' phase. The PERL5LIB >> environment variable may be set in the user's setup file instead. >> --- >> gnu/packages/web.scm | 9 --------- >> 1 file changed, 9 deletions(-) >> >> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm >> index 6467184..b020a6f 100644 >> --- a/gnu/packages/web.scm >> +++ b/gnu/packages/web.scm >> @@ -4850,15 +4850,6 @@ NetSurf project.") >> (arguments >> `(#:phases >> (modify-phases %standard-phases >> - (add-after 'unpack 'include-PERL5LIB-in-wrapper >> - (lambda _ >> - (substitute* "IkiWiki/Wrapper.pm" >> - (("^@wrapper\\_hooks") >> - (string-append >> - "@wrapper_hooks\n" >> - " addenv(\"PERL5LIB\", \"" >> - (getenv "PERL5LIB") >> - "\");"))))) >> (add-after 'patch-source-shebangs 'patch-Makefiles >> (lambda _ >> (substitute* "Makefile.PL" > > Hi Paul, > > So if I remember correctly, this was added so that the Ikiwiki CGI > functionality works, and the commit message mentions this [1] > > 1: http://git.savannah.gnu.org/cgit/guix.git/commit/?id=f4dd303282dc0bfd88606e383c0cf98f3742f771 I don't think there was ever a bug report for this, but I think I've found the IRC conversation for context: http://logs.guix.gnu.org/guix/2017-10-17.log#203630 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl7WDetfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XczEg/8C6gmE9TInBk5ay9lGyIZ9tw01cJKlKn1No9Tv/cJ25X+PpgrKYBB0Zcl n2+lrmH9Z6Sf5XdLNjPfClXIhcpy8j2t/6xgYbzgiXSk4YodiTtpR34rjDZfSC2W omQVrxnCeq0DMVIdzW2XnWrJ6YWSV/Es2lhHNlCwM7Ok/x/e3K6MCMBADmENA74H 9vrt9psq+XPSph2gNwChqGveag9DXze+NaKPmvox0oybUHcL4ZsMSA7f+5hgWk8+ dX2WE+XWAiCxXTi9dA96qCQnW+WOPZCW5BwnNk6OqhHWcSwTjjmeMfhK/FWmr/by KSdgo7R/EuqK1wz7jQ7yGT83YrmRcVZrhh3y5SPWVt1OEwIH506xp3JjV8M5w5aO q44KAaUMktL4Q/nlVMsCFpVlk5jLySqh+0Dbdbi/CGxg5a4oXrefyay2P5Mjem4w +tBP0QJOQ9OA16thq/206yf0pYhmdr3HCPhl35JD248P44S+MyQUOVwut15MJGBc 6HywuxUxcwhjuZrU4RNhf9Ra5ALyTgfrIUzitxAtVBtYbxMCqHGbsIGepW+iBocm xTb8qePeR8Uzjup8wc8/blM1m2I5BKYmEOJUAvW1UY+0/FB6Jo9LKL9G2AgNt275 Passc/8XDt5o2LMvvwf+dVzsN0KXGc+pJBTYW2tjGIBg5qFKr7M= =1HOz -----END PGP SIGNATURE----- --=-=-=--