Re: 01/03: gnu: ikiwiki: Revert to standard wrapper.

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> guix-commits@gnu.org writes:
>
>> pgarlick pushed a commit to branch master
>> in repository guix.
>>
>> commit a0362fdea9369b7927704e48cfc6c578213019ce
>> Author: Paul Garlick <pgarlick@tourbillion-technology.com>
>> AuthorDate: Thu May 28 10:34:40 2020 +0100
>>
>>     gnu: ikiwiki: Revert to standard wrapper.
>>
>>     * gnu/packages/web.scm (ikiwiki)[arguments]: Remove
>>     unnecessary 'include-PERL5LIB-in-wrapper' phase.  The PERL5LIB
>>     environment variable may be set in the user's setup file instead.
>> ---
>>  gnu/packages/web.scm | 9 ---------
>>  1 file changed, 9 deletions(-)
>>
>> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
>> index 6467184..b020a6f 100644
>> --- a/gnu/packages/web.scm
>> +++ b/gnu/packages/web.scm
>> @@ -4850,15 +4850,6 @@ NetSurf project.")
>>      (arguments
>>       `(#:phases
>>         (modify-phases %standard-phases
>> -         (add-after 'unpack 'include-PERL5LIB-in-wrapper
>> -           (lambda _
>> -             (substitute* "IkiWiki/Wrapper.pm"
>> -               (("^@wrapper\\_hooks")
>> -                (string-append
>> -                 "@wrapper_hooks\n"
>> -                 "        addenv(\"PERL5LIB\", \""
>> -                 (getenv "PERL5LIB")
>> -                 "\");")))))
>>           (add-after 'patch-source-shebangs 'patch-Makefiles
>>             (lambda _
>>               (substitute* "Makefile.PL"
>
> Hi Paul,
>
> So if I remember correctly, this was added so that the Ikiwiki CGI
> functionality works, and the commit message mentions this [1]
>
> 1: http://git.savannah.gnu.org/cgit/guix.git/commit/?id=f4dd303282dc0bfd88606e383c0cf98f3742f771

I don't think there was ever a bug report for this, but I think I've
found the IRC conversation for context:

  http://logs.guix.gnu.org/guix/2017-10-17.log#203630

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]