From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add SDL extension libraries
Date: Thu, 21 Nov 2013 22:33:32 +0100
Message-ID: <87li0hxwwj.fsf@gnu.org>
References: <528D745D.1040105@worcester.edu> <87y54iq6yy.fsf@gnu.org>
	<CAJ=RwfaFBu7fUH=EXCwrCuePFjra8BO3yUvuWaRtGG4TWab=Ow@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VjbsZ-0008Ii-Pt
	for guix-devel@gnu.org; Thu, 21 Nov 2013 16:33:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VjbsV-00007B-6f
	for guix-devel@gnu.org; Thu, 21 Nov 2013 16:33:39 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:51907)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VjbsV-00006l-0u
	for guix-devel@gnu.org; Thu, 21 Nov 2013 16:33:35 -0500
In-Reply-To: <CAJ=RwfaFBu7fUH=EXCwrCuePFjra8BO3yUvuWaRtGG4TWab=Ow@mail.gmail.com>
	(David Thompson's message of "Thu, 21 Nov 2013 11:07:40 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

"Thompson, David" <dthompson2@worcester.edu> skribis:

> On Thu, Nov 21, 2013 at 7:23 AM, Ludovic Court=C3=A8s <ludo@gnu.org> wrot=
e:
>> Is the copyright/licensing of these packages clear?  In particular, do
>> all the files within each package have clearly the same license, or a
>> compatible license?  (I=E2=80=99d expect it to be the case given that SD=
L is
>> widespread, but just asking to be sure.)
>
> I will go through the source code and double check.

Thanks.  (Another way to get hints is to look at the Trisquel or Debian
patches, or
<http://libreplanet.org/wiki/List_of_software_that_does_not_respect_the_Fre=
e_System_Distribution_Guidelines>.)

>>> +(define sdl-image
>>> +  (package
>>> +    (name "sdl-image")
>>> +    (version "1.2.12")
>>> +    (source (origin
>>> +             (method url-fetch)
>>> +             (uri
>>> +              (string-append "http://www.libsdl.org/projects/SDL_image=
/release/SDL_image-"
>>> +                             version ".tar.gz"))
>>> +             (sha256
>>> +              (base32
>>> +               "16an9slbb8ci7d89wakkmyfvp7c0cval8xw4hkg0842nhhlp540b")=
)))
>>> +    (build-system gnu-build-system)
>>> +    ;; FIXME: Add webp
>>> +    (propagated-inputs `(("sdl" ,sdl)
>>> +                         ("libpng" ,libpng)
>>> +                         ("libjpeg" ,libjpeg)
>>> +                         ("libtiff" ,libtiff)))
>>
>> Are you sure that all these need to be propagated?
>>
>> (An input typically needs to be propagated if an installed header
>> #includes a header of that input, or if the .pc file mentions that input
>> in its =E2=80=98Requires:=E2=80=99 field.)
>
> I'm pretty sure that they are runtime dependencies, but I will check
> the .pc file and verify.

I wouldn=E2=80=99t be surprised if sdl-image=E2=80=99s headers #include SDL=
=E2=80=99s headers;
dunno about the others.

Thanks,
Ludo=E2=80=99.