[PATCH] gnu: Add libsodium

[PATCH] gnu: Add libsodium

[David Thompson]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

This patch adds a package for a cryptography library called libsodim.  I
created a (gnu packages crypto) module to house similar libraries and
applications in the future.


[-- Attachment #2: 0001-gnu-Add-libsodium.patch --]
[-- Type: text/x-diff, Size: 2889 bytes --]

From 873dffc9dc892ad252a33b2b27f28d41573d6bf7 Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Wed, 25 Jun 2014 20:32:23 -0400
Subject: [PATCH] gnu: Add libsodium.

* gnu-system.am (GNU_SYSTEM_MODULES): Add crypto.scm.
* gnu/packages/crypto.scm: New file.
---
 gnu-system.am           |  1 +
 gnu/packages/crypto.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 gnu/packages/crypto.scm

diff --git a/gnu-system.am b/gnu-system.am
index 9c91eac..a9741b9 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -58,6 +58,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/cpio.scm				\
   gnu/packages/cppi.scm				\
   gnu/packages/cross-base.scm			\
+  gnu/packages/crypto.scm			\
   gnu/packages/cryptsetup.scm			\
   gnu/packages/curl.scm				\
   gnu/packages/cursynth.scm			\
diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
new file mode 100644
index 0000000..e78afb6
--- /dev/null
+++ b/gnu/packages/crypto.scm
@@ -0,0 +1,44 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 David Thompson <davet@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages crypto)
+  #:use-module (gnu packages)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public libsodium
+  (package
+    (name "libsodium")
+    (version "0.5.0")
+    (source (origin
+            (method url-fetch)
+            (uri (string-append
+                  "http://download.libsodium.org/libsodium/releases/libsodium-"
+                  version ".tar.gz"))
+            (sha256
+             (base32
+              "1w7rrnsvhhzhywrr3nhlhppv4kqzdszz3dwy8jrsv8lrj5hs181w"))))
+    (build-system gnu-build-system)
+    (synopsis "Portable NaCl-based crypto library")
+    (description
+     "libsodium is a new easy-to-use high-speed software library for network
+communication, encryption, decryption, signatures, etc.")
+    (license isc)
+    (home-page "https://github.com/jedisct1/libsodium"))) ; No real homepage
-- 
2.0.0


[-- Attachment #3: Type: text/plain, Size: 136 bytes --]


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: Add libsodium

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

On Wed, Jun 25, 2014 at 08:39:33PM -0400, David Thompson wrote:
     This patch adds a package for a cryptography library called libsodim.  I
     created a (gnu packages crypto) module to house similar libraries and
     applications in the future.


So we already have the crypto modules: nettle, gnupg, cyptsetup and mcrypt.
And now we have crypto...
     


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] gnu: Add libsodium

[David Thompson]

John Darrington <john@darrington.wattle.id.au> writes:

> So we already have the crypto modules: nettle, gnupg, cyptsetup and mcrypt.
> And now we have crypto...
>

Yes, I know.  I think we could move those package specific modules into
the crypto module at a later time to clean it up.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: Add libsodium

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> John Darrington <john@darrington.wattle.id.au> writes:
>
>> So we already have the crypto modules: nettle, gnupg, cyptsetup and mcrypt.
>> And now we have crypto...
>>
>
> Yes, I know.  I think we could move those package specific modules into
> the crypto module at a later time to clean it up.

Yes, that may be a good idea (except perhaps for cryptsetup, which
rather belongs in linux.scm, as it’s Linux-specific.)

Ludo’.

Re: [PATCH] gnu: Add libsodium

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> From 873dffc9dc892ad252a33b2b27f28d41573d6bf7 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Wed, 25 Jun 2014 20:32:23 -0400
> Subject: [PATCH] gnu: Add libsodium.
>
> * gnu-system.am (GNU_SYSTEM_MODULES): Add crypto.scm.
> * gnu/packages/crypto.scm: New file.

Looks good to me.

However, the web page reads:

  In order to pick the fastest working implementation of each primitive,
  NaCl performs tests and benchmarks at compile-time.  Unfortunately,
  the resulting library is not guaranteed to work on different hardware.

Which means that Hydra would end up building a version that uses the
specific ISA extensions that happened to be available on the build
machine, which in turn might be unavailable on the user’s machine.

Is there a way to disable the compile-time magic, and instead let
libsodium make the choice at run time?  GMP has --enable-fat for that
purpose.

Thanks,
Ludo’.

PS: Apparently this NaCl is unrelated to Google’s NaCl sandboxing
    thing; terrible!

Re: [PATCH] gnu: Add libsodium

[Thompson, David]

On Thu, Jun 26, 2014 at 8:48 AM, Ludovic Courtès <ludo@gnu.org> wrote:

> However, the web page reads:
>
>   In order to pick the fastest working implementation of each primitive,
>   NaCl performs tests and benchmarks at compile-time.  Unfortunately,
>   the resulting library is not guaranteed to work on different hardware.
>
> Which means that Hydra would end up building a version that uses the
> specific ISA extensions that happened to be available on the build
> machine, which in turn might be unavailable on the user’s machine.
>
> Is there a way to disable the compile-time magic, and instead let
> libsodium make the choice at run time?  GMP has --enable-fat for that
> purpose.

Well, Sodium is a fork on NaCL, and underneath that paragraph it reads:

  Sodium performs tests at run-time, so that the same binary package
can still run everywhere.

So, I think we are okay!  This is a good advantage of Sodium over NaCl.

With that concern out of the way, okay to push?

> PS: Apparently this NaCl is unrelated to Google’s NaCl sandboxing
>     thing; terrible!

Confused me as well.

Thanks.  I appreciate your thorough reviews.

- Dave

Re: [PATCH] gnu: Add libsodium

[Ludovic Courtès]

"Thompson, David" <dthompson2@worcester.edu> skribis:

> On Thu, Jun 26, 2014 at 8:48 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> However, the web page reads:
>>
>>   In order to pick the fastest working implementation of each primitive,
>>   NaCl performs tests and benchmarks at compile-time.  Unfortunately,
>>   the resulting library is not guaranteed to work on different hardware.
>>
>> Which means that Hydra would end up building a version that uses the
>> specific ISA extensions that happened to be available on the build
>> machine, which in turn might be unavailable on the user’s machine.
>>
>> Is there a way to disable the compile-time magic, and instead let
>> libsodium make the choice at run time?  GMP has --enable-fat for that
>> purpose.
>
> Well, Sodium is a fork on NaCL, and underneath that paragraph it reads:
>
>   Sodium performs tests at run-time, so that the same binary package
> can still run everywhere.
>
> So, I think we are okay!  This is a good advantage of Sodium over NaCl.
>
> With that concern out of the way, okay to push?

Oh indeed, I had overlooked that.  OK to push!

Ludo’.