From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: Fwd: [PATCH] Add font-terminus.
Date: Sun, 10 Aug 2014 23:21:59 -0400
Message-ID: <87lhqvr9rc.fsf@yeeloong.lan>
References: <CABXEMcpqX79fF4NVV3fXXZ1P1kHdEaKOGav6pTt977D-xv_mvw@mail.gmail.com>
	<20140810100446.GA5146@debian>
	<CABXEMcpNkYY_Xdq+Op-9Lh35L3BeEMea9tVk3ZeALmtegOxXUQ@mail.gmail.com>
	<CABXEMcoXXbf7Tj465Rv92nrd2sdTOxfXgCR2=MNeO-T2BpyPcQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XGgCQ-0007Z0-Kd
	for guix-devel@gnu.org; Sun, 10 Aug 2014 23:23:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XGgCK-0001ph-In
	for guix-devel@gnu.org; Sun, 10 Aug 2014 23:23:06 -0400
Received: from world.peace.net ([96.39.62.75]:45717)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XGgCK-0001pd-En
	for guix-devel@gnu.org; Sun, 10 Aug 2014 23:23:00 -0400
In-Reply-To: <CABXEMcoXXbf7Tj465Rv92nrd2sdTOxfXgCR2=MNeO-T2BpyPcQ@mail.gmail.com>
	(Guy Grant's message of "Sun, 10 Aug 2014 09:25:59 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Guy Grant <tadnimi@gmail.com>
Cc: guix-devel@gnu.org

Guy Grant <tadnimi@gmail.com> writes:

> Okay, patch updated as recomended; Patch attatched. Again, if
> something looks wrong -- feel free to comment. Thanks!
>
>
> From 3244099f65c1c6bd99d6b0921213c0749e04be47 Mon Sep 17 00:00:00 2001
> From: Guy Grant <tadnimi@gmail.com>
> Date: Sun, 10 Aug 2014 08:58:08 -0500
> Subject: [PATCH 1/1] add terminus-font
>
> ---

This needs a proper commit message.  Look in the git logs for examples.

> +    (inputs
> +      `(("bdftopcf" ,bdftopcf)
> +        ("font-util", font-util)
> +        ("mkfontdir" ,mkfontdir)
> +        ("perl" ,perl)))
> +    (native-inputs
> +      `(("pkg-config" ,pkg-config)))

I suspect that all of those inputs should instead be native-inputs.  If
the code in those packages is executed at build time, then they should
be native-inputs.  If the code is executed at run-time, they should be
normal inputs.  The distinction is important when cross compiling.

> +    (arguments
> +      `(#:configure-flags (list
> +        ;; install fonts into subdirectory of package output instead of
> +        ;; font-util-?.?.?/share/fonts/X11
> +        (string-append "--with-fontrootdir=" %output "/share/fonts/X11"))
> +         #:tests? #f)) ;; No test target in tarball

Please fix the indentation here.

> +    (home-page "http://terminus-font.sourceforge.net/")
> +    (synopsis "Simple bitmap programming font")
> +    (description "Terminus Font is a clean, fixed width bitmap font, designed for long
> + (8 and more hours per day) work with computers.")
> +    (license 
> +     (license:x11-style
> +      "http://scripts.sil.org/cms/scripts/page.php?item_id=OFL_web"))))

Otherwise looks good to me.

    Thanks!
      Mark