From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] utils: Allow wrap-program to be called multiple times.
Date: Wed, 10 Sep 2014 15:40:47 +0200
Message-ID: <87lhprlhk0.fsf@gnu.org>
References: <871trk2yis.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XRi8o-0008Pv-6z
	for guix-devel@gnu.org; Wed, 10 Sep 2014 09:41:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XRi8f-0008TD-6m
	for guix-devel@gnu.org; Wed, 10 Sep 2014 09:40:58 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:37347)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XRi8f-0008T3-06
	for guix-devel@gnu.org; Wed, 10 Sep 2014 09:40:49 -0400
In-Reply-To: <871trk2yis.fsf@member.fsf.org> (Eric Bavier's message of "Tue,
	09 Sep 2014 17:56:59 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@gmail.com> skribis:

> Currently, if (@ (guix build utils) wrap-program) is called multiple
> times for the same file, the original file ends up being overwritten.
> This happened to me when trying to wrap a python program, which had
> already once been wrapped by python-build-system.  The
> python-build-system wrapper sets PYTHON_PATH, and I needed to wrap the
> program again in order to set PATH.

Wouldn=E2=80=99t it be easier or preferable to change =E2=80=98python-build=
-system=E2=80=99 to
offer a way to specify additional arguments for =E2=80=98wrap-program=E2=80=
=99?

The idea of having multiple indirections just to set a bunch of
environment variables doesn=E2=80=99t look appealing to me.

Thanks,
Ludo=E2=80=99.