[PATCH] build-system/perl: Add handling of flags for parallel build and testing.

[PATCH] build-system/perl: Add handling of flags for parallel build and testing.

[Andreas Enge]

The patch below should do what is says... I needed to add the flags in two
places, actually. Can I push it?

Andreas


* guix/build-system/perl.scm (perl-build): Add support for variables
    parallel-build? and parallel-tests?.
* guix/build-system/gnu.scm (gnu-build): Add a line break for clarity.
---
 guix/build-system/gnu.scm  | 3 ++-
 guix/build-system/perl.scm | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index b2b184d..2c41ce0 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -268,7 +268,8 @@ System: GCC, GNU Make, Bash, Coreutils, etc."
                     (out-of-source? #f)
                     (tests? #t)
                     (test-target "check")
-                    (parallel-build? #t) (parallel-tests? #t)
+                    (parallel-build? #t)
+                    (parallel-tests? #t)
                     (patch-shebangs? #t)
                     (strip-binaries? #t)
                     (strip-flags ''("--strip-debug"))
diff --git a/guix/build-system/perl.scm b/guix/build-system/perl.scm
index 5695491..e8fe2d5 100644
--- a/guix/build-system/perl.scm
+++ b/guix/build-system/perl.scm
@@ -47,6 +47,8 @@
                      (perl (default-perl))
                      (search-paths '())
                      (tests? #t)
+                     (parallel-build? #t)
+                     (parallel-tests? #t)
                      (make-maker-flags ''())
                      (phases '(@ (guix build perl-build-system)
                                  %standard-phases))
@@ -79,6 +81,8 @@ provides a `Makefile.PL' file as its build system."
                    #:system ,system
                    #:test-target "test"
                    #:tests? ,tests?
+                   #:parallel-build? ,parallel-build?
+                   #:parallel-tests? ,parallel-tests?
                    #:outputs %outputs
                    #:inputs %build-inputs)))
 
-- 
1.8.4

Re: [PATCH] build-system/perl: Add handling of flags for parallel build and testing.

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> The patch below should do what is says... I needed to add the flags in two
> places, actually. Can I push it?

[...]

> * guix/build-system/perl.scm (perl-build): Add support for variables
>     parallel-build? and parallel-tests?.
> * guix/build-system/gnu.scm (gnu-build): Add a line break for clarity.

Yes, and could you also do that change in python.scm?

Thanks!

Ludo’.

Re: [PATCH] build-system/perl: Add handling of flags for parallel build and testing.

[Andreas Enge]

On Wed, Aug 27, 2014 at 02:23:52PM +0200, Ludovic Courtès wrote:
> > * guix/build-system/perl.scm (perl-build): Add support for variables
> >     parallel-build? and parallel-tests?.
> Yes, and could you also do that change in python.scm?

There I would not know what to do, as the python build system uses
"setup.py" and not "make".

Andreas

Re: [PATCH] build-system/perl: Add handling of flags for parallel build and testing.

[Eric Bavier]

Andreas Enge writes:

> On Wed, Aug 27, 2014 at 02:23:52PM +0200, Ludovic Courtès wrote:
>> > * guix/build-system/perl.scm (perl-build): Add support for variables
>> >     parallel-build? and parallel-tests?.
>> Yes, and could you also do that change in python.scm?
>
> There I would not know what to do, as the python build system uses
> "setup.py" and not "make".

From what I've seen, it would be difficult to extend parallel testing to
python packages, because the method to accomplish this would depend on
the testing framework the package uses.

I don't know that setuptools has any way to build in parallel.  I could
be wrong.

-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html