From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 1/1] gnu: add feh Date: Sun, 05 Oct 2014 12:18:42 +0400 Message-ID: <87lhovj5el.fsf@gmail.com> References: <4c48d1bdc7977e98f1248ad5e9255b0430beb759.1412489062.git.ian@zenhack.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xah1j-0006Ec-6u for guix-devel@gnu.org; Sun, 05 Oct 2014 04:18:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xah1d-0001FD-GY for guix-devel@gnu.org; Sun, 05 Oct 2014 04:18:47 -0400 Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:32903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xah1d-0001F5-89 for guix-devel@gnu.org; Sun, 05 Oct 2014 04:18:41 -0400 Received: by mail-lb0-f174.google.com with SMTP id p9so2882206lbv.33 for ; Sun, 05 Oct 2014 01:18:39 -0700 (PDT) In-Reply-To: <4c48d1bdc7977e98f1248ad5e9255b0430beb759.1412489062.git.ian@zenhack.net> (Ian Denhardt's message of "Sat, 4 Oct 2014 23:32:14 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ian Denhardt Cc: guix-devel@gnu.org Hello, I confirm that the package is built successfully (at least for me). Several comments: There should be a header (a comment with author, license, =E2=80=A6) in the beginning of =E2=80=9Cfeh.scm=E2=80=9D =E2=80=93 see any file in the "gnu/p= ackages" dir. Ian Denhardt (2014-10-05 07:32 +0400) wrote: [...] > +(define-public feh > + (package > + (name "feh") > + (version "2.12") > + (home-page "https://feh.finalrewind.org/") > + (source (origin > + (method url-fetch) > + (uri (string-append home-page > + name "-" version ".tar.bz2")) Double space after =E2=80=98version=E2=80=99. > + (sha256 (base32 > + "0ckhidmsms2l5jycp0qf71jzmb3bpbhjq3bcgfpvfvszah7pmq30"))= )) This is rather unusual indentation. As for me, I prefer: (sha256 (base32 "0ckhidmsms2l5jycp0qf71jzmb3bpbhjq3bcgfpvfvszah7pmq30")) People also use: (sha256 (base32 "0ckhidmsms2l5jycp0qf71jzmb3bpbhjq3bcgfpvfvszah7pmq30")) > + (build-system gnu-build-system) > + (arguments=20 Remove trailing space here please. > + '(#:phases (alist-delete 'configure %standard-phases) > + #:tests? #f > + #:make-flags > + (list "CC=3Dgcc" (string-append "PREFIX=3D" (assoc-ref %output= s "out"))))) > + (inputs `(("imlib2" ,imlib2) > + ("curl" ,curl) > + ("libpng" ,libpng) > + ("libxt" ,libxt) > + ("libx11" ,libx11) > + ("libxinerama" ,libxinerama))) > + (synopsis "Fast and light imlib2-based image viewer") > + (description (string-append > + "feh is an X11 image viewer aimed mostly at console u= sers. " > + "Unlike most other viewers, it does not have a fancy = GUI, " > + "but simply displays images. It is controlled via " > + "commandline arguments and configurable key/mouse act= ions.")) This will make a long one-line description, which is not preferable. Descriptions should be multi-lined and they usually look like this: --8<---------------cut here---------------start------------->8--- (description "feh is an X11 image viewer aimed mostly at console users. Unlike most other viewers, it does not have a fancy GUI, but simply displays images. It is controlled via commandline arguments and configurable key/mouse actions.") --8<---------------cut here---------------end--------------->8--- Also I think it is worth mentioning (in the description) that feh can also be used as a wallpaper setter. --=20 Thanks, Alex