From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/5] emacs: Introduce REPL operation type.
Date: Mon, 27 Oct 2014 10:26:53 +0100
Message-ID: <87lho1982q.fsf@gnu.org>
References: <87r3y147ia.fsf@gmail.com> <87ppdellt1.fsf@gnu.org>
	<87ioj6yn8n.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58779)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XigZX-0001Gx-Da
	for guix-devel@gnu.org; Mon, 27 Oct 2014 05:26:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XigZO-0007W1-8G
	for guix-devel@gnu.org; Mon, 27 Oct 2014 05:26:43 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:41986)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XigZO-0007Vu-1i
	for guix-devel@gnu.org; Mon, 27 Oct 2014 05:26:34 -0400
In-Reply-To: <87ioj6yn8n.fsf@gmail.com> (Alex Kost's message of "Mon, 27 Oct
	2014 10:40:08 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Court=C3=A8s (2014-10-26 21:37 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> This is an auxiliary commit for a =E2=80=9Cpull=E2=80=9D operation adde=
d in a later patch.
>>>
>>>
>>> From ef04333314fbe738d18d33b23a67dc47c8e75dbb Mon Sep 17 00:00:00 2001
>>> From: Alex Kost <alezost@gmail.com>
>>> Date: Mon, 20 Oct 2014 23:18:13 +0400
>>> Subject: [PATCH 2/5] emacs: Introduce REPL operation type.
>>>
>>> * emacs/guix-backend.el (guix-repl-operation-type): New variable.
>>>   (guix-repl-output-filter): Run type hooks after performing an operati=
on.
>>>   (guix-eval-read): Add 'operation-type' argument.
>>
>> [...]
>>
>>> +(defvar guix-repl-operation-type nil
>>> +  "Type of the current operation performed by `guix-eval-in-repl'.")
>>
>> Could you write something about the valid values it may take and their
>> meaning?

Sorry, I meant as comment in the docstring above.  :-)

>> Otherwise LGTM.
>
> It's an internal variable set by =E2=80=98guix-eval-in-repl=E2=80=99.
>
> The point of an =E2=80=9Coperation type=E2=80=9D is to run some specializ=
ed actions
> after finishing a REPL operation (e.g., to refresh buffers after =E2=80=
=98pull=E2=80=99
> operation).
>
> If there is =E2=80=98guix-after-foo-hook=E2=80=99 variable and =E2=80=98g=
uix-eval-in-repl=E2=80=99 is
> called with =E2=80=98foo=E2=80=99 operation-type, the hooks from that var=
 will be called
> after executing =E2=80=98foo=E2=80=99 operation.
>
> Currently only =E2=80=98pull=E2=80=99 operation type is used, so =E2=80=
=98guix-after-pull-hook=E2=80=99
> is called after a pull operation.

OK, thanks.  Feel free to commit with the explanation folded into the
docstring.

Ludo=E2=80=99.