unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: libxml2: Propagate input zlib.
@ 2015-02-11 13:30 宋文武
  2015-02-11 22:44 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: 宋文武 @ 2015-02-11 13:30 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/xml.scm (libxml2): Move zlib to 'propagated-inputs'.
---
 gnu/packages/xml.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index f2b3baa..173435d 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -65,7 +65,7 @@ things the parser might find in the XML document (like start tags).")
     (build-system gnu-build-system)
     (home-page "http://www.xmlsoft.org/")
     (synopsis "C parser for XML")
-    (inputs `(("zlib" ,zlib)))
+    (propagated-inputs `(("zlib" ,zlib))) ; libxml2.la says '-lz'.
     (native-inputs `(("perl" ,perl)
                      ("python" ,python-2))) ; incompatible with Python 3 (print syntax)
 
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: libxml2: Propagate input zlib.
  2015-02-11 13:30 [PATCH] gnu: libxml2: Propagate input zlib 宋文武
@ 2015-02-11 22:44 ` Ludovic Courtès
  2015-02-12 13:21   ` 宋文武
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2015-02-11 22:44 UTC (permalink / raw)
  To: 宋文武; +Cc: guix-devel

宋文武 <iyzsong@gmail.com> skribis:

> * gnu/packages/xml.scm (libxml2): Move zlib to 'propagated-inputs'.

Did you encounter an issue in practice?  It’s only a problem for static
linking.

I’m asking partly because 452 packages would need to be rebuilt.

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: libxml2: Propagate input zlib.
  2015-02-11 22:44 ` Ludovic Courtès
@ 2015-02-12 13:21   ` 宋文武
  2015-02-12 20:43     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: 宋文武 @ 2015-02-12 13:21 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Ludovic Courtès <ludo@gnu.org> writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/xml.scm (libxml2): Move zlib to 'propagated-inputs'.
>
> Did you encounter an issue in practice?  It’s only a problem for static
> linking.
Yes, zlib is required for libxklavier (it not use zlib but libxml2).
I try libxklavier with '--disable-static', but '-lz' is still there.
>
> I’m asking partly because 452 packages would need to be rebuilt.
Ah, in this case, I think add 'zlib' to libxklavier should be ok?
>
> Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: libxml2: Propagate input zlib.
  2015-02-12 13:21   ` 宋文武
@ 2015-02-12 20:43     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2015-02-12 20:43 UTC (permalink / raw)
  To: 宋文武; +Cc: guix-devel

宋文武 <iyzsong@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> 宋文武 <iyzsong@gmail.com> skribis:
>>
>>> * gnu/packages/xml.scm (libxml2): Move zlib to 'propagated-inputs'.
>>
>> Did you encounter an issue in practice?  It’s only a problem for static
>> linking.
> Yes, zlib is required for libxklavier (it not use zlib but libxml2).
> I try libxklavier with '--disable-static', but '-lz' is still there.

Hmm, OK.

>> I’m asking partly because 452 packages would need to be rebuilt.
> Ah, in this case, I think add 'zlib' to libxklavier should be ok?

Yeah, but your initial patch really is the right fix.  So let’s push it.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-02-12 20:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-11 13:30 [PATCH] gnu: libxml2: Propagate input zlib 宋文武
2015-02-11 22:44 ` Ludovic Courtès
2015-02-12 13:21   ` 宋文武
2015-02-12 20:43     ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).