From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] Update ncmpcpp to v0.6.2
Date: Fri, 27 Feb 2015 11:13:12 -0500
Message-ID: <87lhjj72p3.fsf@netris.org>
References: <87sidrll19.fsf@denknerd.org> <87vbin8qo2.fsf@fsf.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59474)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YRNXO-0001VO-KV
	for guix-devel@gnu.org; Fri, 27 Feb 2015 11:13:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YRNXL-0003dc-9n
	for guix-devel@gnu.org; Fri, 27 Feb 2015 11:13:14 -0500
Received: from world.peace.net ([50.252.239.5]:43820)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YRNXL-0003Z5-4l
	for guix-devel@gnu.org; Fri, 27 Feb 2015 11:13:11 -0500
In-Reply-To: <87vbin8qo2.fsf@fsf.org> (David Thompson's message of "Fri, 27
	Feb 2015 07:50:05 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: Guix-devel <guix-devel@gnu.org>

David Thompson <dthompson2@worcester.edu> writes:

> Paul van der Walt <paul@denknerd.org> writes:
[...]
>> +    (arguments
>> +     '(#:configure-flags
>> +       '("BOOST_LIB_SUFFIX=")
>> +       #:phases
>> +       (alist-cons-after
>> +        'unpack 'autogen
>> +        (lambda _
>> +          (substitute* "autogen.sh"
>> +            (("/bin/sh") (which "bash")))
>
> Is "autogen.sh" not executable?  If it starts with a shebang, Guix
> should patch the file appropriately.

The problem here is that this 'autogen' phase is run before the
'patch-source-shebangs' phase, at my suggestion.  It has to be that way,
because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
be run on the files created by 'autogen.sh'.

>> +          (setenv "NOCONFIGURE" "true")
>> +          (zero? (system* "bash" "autogen.sh")))
>
> If its executable, you can say:
>
>     (zero? (system* "./autogen.sh"))

Yes, after the 'substitute*' above, this should presumably work.  My
guess is that Paul added the "bash" here before he realized that he
also needed the 'substitute*'.

      Mark