From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add FASTX Toolkit.
Date: Wed, 15 Apr 2015 22:05:00 +0200
Message-ID: <87lhhtximr.fsf@gnu.org>
References: <idjr3rmyds2.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YiTYb-00022O-K2
	for guix-devel@gnu.org; Wed, 15 Apr 2015 16:05:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YiTYX-00075V-GM
	for guix-devel@gnu.org; Wed, 15 Apr 2015 16:05:09 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39258)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YiTYX-00075H-EN
	for guix-devel@gnu.org; Wed, 15 Apr 2015 16:05:05 -0400
In-Reply-To: <idjr3rmyds2.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Tue, 14 Apr 2015 16:39:57 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> "fastx-toolkit" installs three m4 files to "$out/share/aclocal", and
> libgtextutils installs an empty "$out/share/aclocal" directoy.  I
> reported this upstream, but I did not add a phase to remove these files,
> because I think it's not a big deal.  Is this okay or should I modify
> the sources to avoid installing these files?

What=E2=80=99s wrong with these files?  It looks fine to me, and it=E2=80=
=99s the
standard directory for Autoconf macros.  So no problem IMO.  :-)

> From 673f316fd41b0d0d7679a7a69ed4755923873653 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 14 Apr 2015 16:35:30 +0200
> Subject: [PATCH 1/2] gnu: Add libgtextutils.
>
> * gnu/packages/textutils.scm (libgtextutils): New variable.

[...]

> +     '(#:phases
> +       (alist-cons-after
> +        'unpack 'autoreconf
> +        (lambda _ (zero? (system* "autoreconf" "-vif")))

So there=E2=80=99s no =E2=80=98make dist=E2=80=99 tarball I suppose?

> +    (home-page "http://hannonlab.cshl.edu/fastx_toolkit")

Maybe the github.com URL?

> +    (synopsis "Gordon's text utils library")
> +    (description
> +     "libgtextutils is a text utilities library

Not satisfying but apparently there=E2=80=99s nothing in the REAME nor in t=
he
doc so we=E2=80=99ll live with it.

> From 1d386b93064eb839e0156938ac38919daa654839 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 14 Apr 2015 16:36:30 +0200
> Subject: [PATCH 2/2] gnu: Add FASTX Toolkit.
>
> * gnu/packages/bioinformatics.scm (fastx-toolkit): New variable.

LGTM!

Thanks,
Ludo=E2=80=99.