From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add FASTX Toolkit.
Date: Wed, 15 Apr 2015 22:05:00 +0200 [thread overview]
Message-ID: <87lhhtximr.fsf@gnu.org> (raw)
In-Reply-To: <idjr3rmyds2.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Tue, 14 Apr 2015 16:39:57 +0200")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> "fastx-toolkit" installs three m4 files to "$out/share/aclocal", and
> libgtextutils installs an empty "$out/share/aclocal" directoy. I
> reported this upstream, but I did not add a phase to remove these files,
> because I think it's not a big deal. Is this okay or should I modify
> the sources to avoid installing these files?
What’s wrong with these files? It looks fine to me, and it’s the
standard directory for Autoconf macros. So no problem IMO. :-)
> From 673f316fd41b0d0d7679a7a69ed4755923873653 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 14 Apr 2015 16:35:30 +0200
> Subject: [PATCH 1/2] gnu: Add libgtextutils.
>
> * gnu/packages/textutils.scm (libgtextutils): New variable.
[...]
> + '(#:phases
> + (alist-cons-after
> + 'unpack 'autoreconf
> + (lambda _ (zero? (system* "autoreconf" "-vif")))
So there’s no ‘make dist’ tarball I suppose?
> + (home-page "http://hannonlab.cshl.edu/fastx_toolkit")
Maybe the github.com URL?
> + (synopsis "Gordon's text utils library")
> + (description
> + "libgtextutils is a text utilities library
Not satisfying but apparently there’s nothing in the REAME nor in the
doc so we’ll live with it.
> From 1d386b93064eb839e0156938ac38919daa654839 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 14 Apr 2015 16:36:30 +0200
> Subject: [PATCH 2/2] gnu: Add FASTX Toolkit.
>
> * gnu/packages/bioinformatics.scm (fastx-toolkit): New variable.
LGTM!
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-04-15 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 14:39 [PATCH] Add FASTX Toolkit Ricardo Wurmus
2015-04-15 20:05 ` Ludovic Courtès [this message]
2015-04-16 8:31 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhhtximr.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).