From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH 0/4] Add sra-tools.
Date: Fri, 17 Apr 2015 14:42:40 +0200
Message-ID: <87lhhr2af3.fsf@mango.localdomain>
References: <idjvbgyyiny.fsf@bimsb-sys02.mdc-berlin.net>
	<87383zdv9v.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34739)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Yj5bl-0003QQ-NP
	for guix-devel@gnu.org; Fri, 17 Apr 2015 08:42:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Yj5bf-0004Mg-9w
	for guix-devel@gnu.org; Fri, 17 Apr 2015 08:42:57 -0400
In-Reply-To: <87383zdv9v.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s writes:

>> I had to remove libxml2 from the inputs to sra-tools, resulting in a
>> failure to build a couple of loader tools.  The reason for this is tha=
t
>> I encountered linker problems like these:
>
> It looks like an upstream bug?  And why is it being statically-linked
> anyway?  It would be nice if they would default to dynamic linking,
> which is more efficient in terms of memory use, etc.

Indeed.  I will file a bug report upstream.

>> +    (synopsis "API for accessing Next Generation Sequencing data")
>
> I would put quotes around =E2=80=9CNext Generation=E2=80=9D.  :-)

"Next-generation sequencing" is an actual term (although it sounds a
little silly).  It refers to high-throughput sequencing technology.

See http://www.nature.com/subjects/next-generation-sequencing

>> +    (synopsis "Java bindings for NGS SDK")
>> +    (description
>> +     (string-append (package-description ngs-sdk)
>> +                    "\n\nThis package contains the Java bindings.")))=
)
>
> =E2=80=98description=E2=80=99 should be a string literal, otherwise xge=
ttext won=E2=80=99t catch
> it, thereby preventing i18n.
>
> What I would do is just keep =E2=80=98description=E2=80=99 unchanged, o=
r rewrite it.
> Keeping it unchanged is OK here since the synopsis makes it clear that
> these are Java bindings.

Okay, I'll just keep the inherited description then.  I should note that
"python-wrapper" in python.scm also does not use a string literal.

~~ Ricardo