Re: [PATCH] build: ruby: Rewrite build system to use gem archives.

[Ricardo Wurmus <rekado@elephly.net>]

Thompson, David <dthompson2@worcester.edu> writes:

>> The major change from the previous version of this patch is that I
>> figured how to unpack the source gem, allow the package build script
>> to make any necessary dynamic patches, and then install a repacked gem
>> as opposed to the source gem.
>
> I found a problem with this system when it came to running certain
> test suites that used Bundler to read the gemspec.  A lot of upstream
> gemspec include things like shell commands to run 'git ls-files' and
> things.  In the former build system, the 'gitify' phase took care of
> this.  Now, we can more easily deal with it by asking the 'gem'
> utility to generate a gemspec for us based on the source gem archive.
> Hope that wasn't too confusing for the non-Rubyists.

I just read through the patch set.  Looks good!  (Note: I haven’t
actually tested this yet.)

It seems that you had to disable tests for “useragent”, “arel”, “git”; I
assume that’s because the gems do not come with the necessary test
files.  I remember a link to a discussion you once shared, in which it
was said that the declaration of test files in gemspec manifests is
deprecated.  Do you think the absence of tests in the published gems is
going to be a problem for many more packages?

~~ Ricardo