unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul van der Walt <paul@denknerd.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add dosbox x86 emulator.
Date: Wed, 21 Oct 2015 22:12:26 +0200	[thread overview]
Message-ID: <87lhawrnf9.fsf@denknerd.org> (raw)
In-Reply-To: <87si546mbn.fsf@gnu.org>


On 2015-10-21 at 21:41, quoth Ludovic Courtès:
>> +    (name "dosbox")
>> +    (version "0.74")
>
> Rather 0.74.svn3947 or similar.

Right, fixed.

>> +              ;; Using SVN head, since the last release (2010) is incompatible
>> +              ;; with GCC5 (see
>> +              ;; <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=624976>).
>
> Sure, but we’re currently building with GCC 4.9.  :-)  Anyway, we’ll have
> the problem sooner or later, so this is probably wise.

I've fixed the comment.  IIUC it's actually a problem with GCC 4.8+, but
anyway :).

>> +    (description "DOSBox is a DOS-emulator that uses the SDL-library.  DOSBox
>
> “the SDL library”

Done.

>> +    (license license:gpl3)))
>
> According to dosbox-0.74.tar.gz, it’s GPLv2+, not GPLv3-only.  Could you
> double check?

You're right, fixed.

Cheers,
p.

  reply	other threads:[~2015-10-21 20:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 13:25 [PATCH] gnu: Add dosbox x86 emulator Paul van der Walt
2015-10-21 19:41 ` Ludovic Courtès
2015-10-21 20:12   ` Paul van der Walt [this message]
2015-10-21 22:40 ` Mark H Weaver
2015-10-22  9:13   ` Paul van der Walt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhawrnf9.fsf@denknerd.org \
    --to=paul@denknerd.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).