* [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
@ 2015-12-08 17:18 Mathieu Lirzin
2015-12-09 3:24 ` Leo Famulari
2015-12-09 13:52 ` Ludovic Courtès
0 siblings, 2 replies; 10+ messages in thread
From: Mathieu Lirzin @ 2015-12-08 17:18 UTC (permalink / raw)
To: guix-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-rxvt-unicode-Add-the-terminal-capability-data.patch --]
[-- Type: text/x-diff, Size: 2818 bytes --]
From 00d45cdc47bd0d031d0870155e24fa814dad4833 Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@gnu.org>
Date: Sun, 6 Dec 2015 21:58:03 +0100
Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
This adds the necessary terminal capability data which are not provided
by Ncurses due to a personal conflict between the respective
maintainers. See
https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
* gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
[arguments]: Set the destination of the terminfo files.
---
gnu/packages/xdisorg.scm | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 4b5308c..df8aa99 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -40,6 +40,7 @@
#:use-module (gnu packages gettext)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome) ;for libgudev
+ #:use-module (gnu packages ncurses)
#:use-module (gnu packages perl)
#:use-module (gnu packages python)
#:use-module (gnu packages linux)
@@ -529,23 +530,28 @@ compact configuration syntax.")
(package
(name "rxvt-unicode")
(version "9.21")
- (source
- (origin
- (method url-fetch)
- (uri (string-append
- "http://dist.schmorp.de/rxvt-unicode/"
- name "-"
- version
- ".tar.bz2"))
- (sha256
- (base32
- "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://dist.schmorp.de/rxvt-unicode/"
+ name "-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
(build-system gnu-build-system)
+ (arguments
+ ;; This sets the destination when installing the necessary terminal
+ ;; capability data which are not provided by Ncurses due to a personal
+ ;; conflict between the respective maintainers. See
+ ;; https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
+ '(#:make-flags (list (string-append "TERMINFO="
+ (assoc-ref %outputs "out")
+ "/share/terminfo"))))
(inputs
`(("libXft" ,libxft)
("libX11" ,libx11)))
(native-inputs
- `(("perl" ,perl)
+ `(("ncurses" ,ncurses) ;trigger the installation of terminfo data
+ ("perl" ,perl)
("pkg-config" ,pkg-config)))
(home-page "http://software.schmorp.de/pkg/rxvt-unicode.html")
(synopsis "Rxvt clone with XFT and unicode support")
--
2.6.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-08 17:18 [PATCH] gnu: rxvt-unicode: Add the terminal capability data Mathieu Lirzin
@ 2015-12-09 3:24 ` Leo Famulari
2015-12-09 14:12 ` Mathieu Lirzin
2015-12-09 13:52 ` Ludovic Courtès
1 sibling, 1 reply; 10+ messages in thread
From: Leo Famulari @ 2015-12-09 3:24 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel
On Tue, Dec 08, 2015 at 06:18:50PM +0100, Mathieu Lirzin wrote:
> From 00d45cdc47bd0d031d0870155e24fa814dad4833 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Sun, 6 Dec 2015 21:58:03 +0100
> Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
>
> This adds the necessary terminal capability data which are not provided
> by Ncurses due to a personal conflict between the respective
> maintainers. See
> https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
>
> * gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
> [arguments]: Set the destination of the terminfo files.
> ---
> gnu/packages/xdisorg.scm | 30 ++++++++++++++++++------------
> 1 file changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> index 4b5308c..df8aa99 100644
> --- a/gnu/packages/xdisorg.scm
> +++ b/gnu/packages/xdisorg.scm
> @@ -40,6 +40,7 @@
> #:use-module (gnu packages gettext)
> #:use-module (gnu packages glib)
> #:use-module (gnu packages gnome) ;for libgudev
> + #:use-module (gnu packages ncurses)
> #:use-module (gnu packages perl)
> #:use-module (gnu packages python)
> #:use-module (gnu packages linux)
> @@ -529,23 +530,28 @@ compact configuration syntax.")
> (package
> (name "rxvt-unicode")
> (version "9.21")
> - (source
> - (origin
> - (method url-fetch)
> - (uri (string-append
> - "http://dist.schmorp.de/rxvt-unicode/"
> - name "-"
> - version
> - ".tar.bz2"))
> - (sha256
> - (base32
> - "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "http://dist.schmorp.de/rxvt-unicode/"
> + name "-" version ".tar.bz2"))
> + (sha256
> + (base32
> + "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
> (build-system gnu-build-system)
> + (arguments
> + ;; This sets the destination when installing the necessary terminal
> + ;; capability data which are not provided by Ncurses due to a personal
> + ;; conflict between the respective maintainers. See
> + ;; https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
I think it's best not to describe the issue in these terms in the
codebase. I don't know the situation, but if it is as you say, I think
it will never get better as things like this "cement" the conflict in
source code. Also, ncurses seems to be capitalized only at the beginning
of a sentence. How about this:
This sets the destination when installing the necessary terminal
capability data, which are not provided by ncurses. See
https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html
> + '(#:make-flags (list (string-append "TERMINFO="
> + (assoc-ref %outputs "out")
> + "/share/terminfo"))))
> (inputs
> `(("libXft" ,libxft)
> ("libX11" ,libx11)))
> (native-inputs
> - `(("perl" ,perl)
> + `(("ncurses" ,ncurses) ;trigger the installation of terminfo data
> + ("perl" ,perl)
> ("pkg-config" ,pkg-config)))
> (home-page "http://software.schmorp.de/pkg/rxvt-unicode.html")
> (synopsis "Rxvt clone with XFT and unicode support")
> --
> 2.6.3
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-08 17:18 [PATCH] gnu: rxvt-unicode: Add the terminal capability data Mathieu Lirzin
2015-12-09 3:24 ` Leo Famulari
@ 2015-12-09 13:52 ` Ludovic Courtès
2015-12-09 17:58 ` Mathieu Lirzin
1 sibling, 1 reply; 10+ messages in thread
From: Ludovic Courtès @ 2015-12-09 13:52 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel
Mathieu Lirzin <mthl@gnu.org> skribis:
> From 00d45cdc47bd0d031d0870155e24fa814dad4833 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Sun, 6 Dec 2015 21:58:03 +0100
> Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
>
> This adds the necessary terminal capability data which are not provided
> by Ncurses due to a personal conflict between the respective
> maintainers. See
> https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
As Leo suggests, I think it’s best to stick to the technical facts,
along with a link to the discussion.
> * gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
> [arguments]: Set the destination of the terminfo files.
> + (arguments
> + ;; This sets the destination when installing the necessary terminal
> + ;; capability data which are not provided by Ncurses due to a personal
> + ;; conflict between the respective maintainers. See
> + ;; https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
Same here.
Otherwise LGTM. It’s great that you fixed this! People had reported
the issue on IRC, so that’ll make them happy! :-)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-09 3:24 ` Leo Famulari
@ 2015-12-09 14:12 ` Mathieu Lirzin
0 siblings, 0 replies; 10+ messages in thread
From: Mathieu Lirzin @ 2015-12-09 14:12 UTC (permalink / raw)
To: Leo Famulari; +Cc: guix-devel
Leo Famulari <leo@famulari.name> writes:
> On Tue, Dec 08, 2015 at 06:18:50PM +0100, Mathieu Lirzin wrote:
>> From 00d45cdc47bd0d031d0870155e24fa814dad4833 Mon Sep 17 00:00:00 2001
>> From: Mathieu Lirzin <mthl@gnu.org>
>> Date: Sun, 6 Dec 2015 21:58:03 +0100
>> Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
>>
>> This adds the necessary terminal capability data which are not provided
>> by Ncurses due to a personal conflict between the respective
>> maintainers. See
>> https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
>>
>> * gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
>> [arguments]: Set the destination of the terminfo files.
[...]
> I think it's best not to describe the issue in these terms in the
> codebase. I don't know the situation, but if it is as you say, I think
> it will never get better as things like this "cement" the conflict in
> source code. Also, ncurses seems to be capitalized only at the beginning
> of a sentence. How about this:
>
> This sets the destination when installing the necessary terminal
> capability data, which are not provided by ncurses. See
> https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html
I will use this.
Thanks for your suggestion.
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-09 13:52 ` Ludovic Courtès
@ 2015-12-09 17:58 ` Mathieu Lirzin
2015-12-09 20:54 ` Ludovic Courtès
0 siblings, 1 reply; 10+ messages in thread
From: Mathieu Lirzin @ 2015-12-09 17:58 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 2301 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> Otherwise LGTM. It’s great that you fixed this! People had reported
> the issue on IRC, so that’ll make them happy! :-)
I think this is only a partial fix. to launch emacsclient I still need
to do this:
TERMINFO="$HOME/.guix-profile/share/terminfo" emacsclient --tty foo
in terminfo(5), we can read this:
--8<---------------cut here---------------start------------->8---
Fetching Compiled Descriptions
The ncurses library searches for terminal descriptions in several
places. It uses only the first description found. The library has a
compiled-in list of places to search which can be overridden by envi‐
ronment variables. Before starting to search, ncurses eliminates
duplicates in its search list.
· If the environment variable TERMINFO is set, it is interpreted as
the pathname of a directory containing the compiled description you
are working on. Only that directory is searched.
· If TERMINFO is not set, ncurses will instead look in the directory
$HOME/.terminfo for a compiled description.
· Next, if the environment variable TERMINFO_DIRS is set, ncurses
will interpret the contents of that variable as a list of colon-
separated directories (or database files) to be searched.
An empty directory name (i.e., if the variable begins or ends with
a colon, or contains adjacent colons) is interpreted as the system
location /etc/terminfo.
· Finally, ncurses searches these compiled-in locations:
· a list of directories (no default value), and
· the system terminfo directory, /etc/terminfo (the compiled-in
default).
--8<---------------cut here---------------end--------------->8---
I suppose that "system terminfo directory" is set to
/gnu/store/...-ncurses-6.0 and IIUC correctly this is the only place
automatically searched. What about adding TERMINFO_DIRS in
"$HOME/.guix-profile/etc/profile"? I think TERMINFO_DIRS is more
appropriate than TERMINFO because it let the possibility for non-GuixSD
users to have multiple directories in it.
Here is an updated patch with my proposal:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-rxvt-unicode-Add-the-terminal-capability-data.patch --]
[-- Type: text/x-diff, Size: 3025 bytes --]
From eedb9ca34c5bbc973765c8bd8a17b0a42c98e427 Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@gnu.org>
Date: Sun, 6 Dec 2015 21:58:03 +0100
Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
This sets the destination when installing the necessary terminal
capability data, which are not provided by ncurses. See
https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html
* gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
[arguments]: Set the destination of the terminfo files.
[native-search-path]: New field. Make them automatically available to
the user.
---
gnu/packages/xdisorg.scm | 33 +++++++++++++++++++++------------
1 file changed, 21 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 4b5308c..ab48b2a 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -40,6 +40,7 @@
#:use-module (gnu packages gettext)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome) ;for libgudev
+ #:use-module (gnu packages ncurses)
#:use-module (gnu packages perl)
#:use-module (gnu packages python)
#:use-module (gnu packages linux)
@@ -529,24 +530,32 @@ compact configuration syntax.")
(package
(name "rxvt-unicode")
(version "9.21")
- (source
- (origin
- (method url-fetch)
- (uri (string-append
- "http://dist.schmorp.de/rxvt-unicode/"
- name "-"
- version
- ".tar.bz2"))
- (sha256
- (base32
- "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://dist.schmorp.de/rxvt-unicode/"
+ name "-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
(build-system gnu-build-system)
+ (arguments
+ ;; This sets the destination when installing the necessary terminal
+ ;; capability data, which are not provided by ncurses. See
+ ;; https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html
+ '(#:make-flags (list (string-append "TERMINFO="
+ (assoc-ref %outputs "out")
+ "/share/terminfo"))))
(inputs
`(("libXft" ,libxft)
("libX11" ,libx11)))
(native-inputs
- `(("perl" ,perl)
+ `(("ncurses" ,ncurses) ;trigger the installation of terminfo data
+ ("perl" ,perl)
("pkg-config" ,pkg-config)))
+ (native-search-paths
+ (list (search-path-specification
+ (variable "TERMINFO_DIRS")
+ (files '("share/terminfo")))))
(home-page "http://software.schmorp.de/pkg/rxvt-unicode.html")
(synopsis "Rxvt clone with XFT and unicode support")
(description "Rxvt-unicode (urxvt) is a colour vt102 terminal emulator
--
2.6.3
[-- Attachment #3: Type: text/plain, Size: 28 bytes --]
Thanks,
--
Mathieu Lirzin
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-09 17:58 ` Mathieu Lirzin
@ 2015-12-09 20:54 ` Ludovic Courtès
2015-12-09 21:26 ` Leo Famulari
2015-12-10 2:57 ` Mathieu Lirzin
0 siblings, 2 replies; 10+ messages in thread
From: Ludovic Courtès @ 2015-12-09 20:54 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel
Mathieu Lirzin <mthl@gnu.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Otherwise LGTM. It’s great that you fixed this! People had reported
>> the issue on IRC, so that’ll make them happy! :-)
>
> I think this is only a partial fix. to launch emacsclient I still need
> to do this:
>
> TERMINFO="$HOME/.guix-profile/share/terminfo" emacsclient --tty foo
>
> in terminfo(5), we can read this:
[...]
> I suppose that "system terminfo directory" is set to
> /gnu/store/...-ncurses-6.0 and IIUC correctly this is the only place
> automatically searched. What about adding TERMINFO_DIRS in
> "$HOME/.guix-profile/etc/profile"? I think TERMINFO_DIRS is more
> appropriate than TERMINFO because it let the possibility for non-GuixSD
> users to have multiple directories in it.
Indeed, sounds good.
> From eedb9ca34c5bbc973765c8bd8a17b0a42c98e427 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Sun, 6 Dec 2015 21:58:03 +0100
> Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
>
> This sets the destination when installing the necessary terminal
> capability data, which are not provided by ncurses. See
> https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html
>
> * gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
> [arguments]: Set the destination of the terminfo files.
> [native-search-path]: New field. Make them automatically available to
> the user.
[...]
> + (native-search-paths
> + (list (search-path-specification
> + (variable "TERMINFO_DIRS")
> + (files '("share/terminfo")))))
This should be in the ncurses package itself, since it is “owned” by
ncurses, not rxvt.
However, there’s the limitation that, currently, --search-paths
advertises the variables of things that are explicitly in the profile.
Ncurses is usually not in the profile; it is a dependency of something
that is in the profile. Thus, people wouldn’t see anything about
TERMINFO_DIRS in practice (we have the same problem with OpenSSL,
GStreamer, and other librairies that have associated variables.)
Long story short, I would avoid adding this ‘native-search-paths’ here,
but I’m OK with it since that would make the thing usable, provided
there’s a big FIXME in there.
WDYT?
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-09 20:54 ` Ludovic Courtès
@ 2015-12-09 21:26 ` Leo Famulari
2015-12-10 3:21 ` Mathieu Lirzin
2015-12-10 2:57 ` Mathieu Lirzin
1 sibling, 1 reply; 10+ messages in thread
From: Leo Famulari @ 2015-12-09 21:26 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
On Wed, Dec 09, 2015 at 09:54:15PM +0100, Ludovic Courtès wrote:
> Mathieu Lirzin <mthl@gnu.org> skribis:
>
> > ludo@gnu.org (Ludovic Courtès) writes:
> >
> >> Otherwise LGTM. It’s great that you fixed this! People had reported
> >> the issue on IRC, so that’ll make them happy! :-)
> >
> > I think this is only a partial fix. to launch emacsclient I still need
> > to do this:
> >
> > TERMINFO="$HOME/.guix-profile/share/terminfo" emacsclient --tty foo
> >
> > in terminfo(5), we can read this:
>
> [...]
>
> > I suppose that "system terminfo directory" is set to
> > /gnu/store/...-ncurses-6.0 and IIUC correctly this is the only place
> > automatically searched. What about adding TERMINFO_DIRS in
> > "$HOME/.guix-profile/etc/profile"? I think TERMINFO_DIRS is more
> > appropriate than TERMINFO because it let the possibility for non-GuixSD
> > users to have multiple directories in it.
>
> Indeed, sounds good.
>
> > From eedb9ca34c5bbc973765c8bd8a17b0a42c98e427 Mon Sep 17 00:00:00 2001
> > From: Mathieu Lirzin <mthl@gnu.org>
> > Date: Sun, 6 Dec 2015 21:58:03 +0100
> > Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
> >
> > This sets the destination when installing the necessary terminal
> > capability data, which are not provided by ncurses. See
> > https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html
> >
> > * gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
> > [arguments]: Set the destination of the terminfo files.
> > [native-search-path]: New field. Make them automatically available to
> > the user.
>
> [...]
>
> > + (native-search-paths
> > + (list (search-path-specification
> > + (variable "TERMINFO_DIRS")
> > + (files '("share/terminfo")))))
>
> This should be in the ncurses package itself, since it is “owned” by
> ncurses, not rxvt.
>
> However, there’s the limitation that, currently, --search-paths
> advertises the variables of things that are explicitly in the profile.
> Ncurses is usually not in the profile; it is a dependency of something
> that is in the profile. Thus, people wouldn’t see anything about
> TERMINFO_DIRS in practice (we have the same problem with OpenSSL,
> GStreamer, and other librairies that have associated variables.)
>
> Long story short, I would avoid adding this ‘native-search-paths’ here,
> but I’m OK with it since that would make the thing usable, provided
> there’s a big FIXME in there.
>
> WDYT?
Since the linked discussion is from 2009, maybe somebody should again
try to politely submit the patch upstream.
>
> Ludo’.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-09 20:54 ` Ludovic Courtès
2015-12-09 21:26 ` Leo Famulari
@ 2015-12-10 2:57 ` Mathieu Lirzin
2015-12-10 9:42 ` Ludovic Courtès
1 sibling, 1 reply; 10+ messages in thread
From: Mathieu Lirzin @ 2015-12-10 2:57 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
ludo@gnu.org (Ludovic Courtès) writes:
> Mathieu Lirzin <mthl@gnu.org> skribis:
[...]
>> + (native-search-paths
>> + (list (search-path-specification
>> + (variable "TERMINFO_DIRS")
>> + (files '("share/terminfo")))))
>
> This should be in the ncurses package itself, since it is “owned” by
> ncurses, not rxvt.
>
> However, there’s the limitation that, currently, --search-paths
> advertises the variables of things that are explicitly in the profile.
> Ncurses is usually not in the profile; it is a dependency of something
> that is in the profile. Thus, people wouldn’t see anything about
> TERMINFO_DIRS in practice (we have the same problem with OpenSSL,
> GStreamer, and other librairies that have associated variables.)
>
> Long story short, I would avoid adding this ‘native-search-paths’ here,
> but I’m OK with it since that would make the thing usable, provided
> there’s a big FIXME in there.
>
> WDYT?
It makes sense. Since it is quite complicated, what about creating a
bug report explaining the problem and make the comment refer to it like
this:
;; FIXME: This is not located in `ncurses' for usability reasons. See
;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=XXXXX
WDYT? Can you take care of creating the bug report or propose an
appropriate FIXME comment? I don't feel up to explaining this myself.
Thanks,
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-09 21:26 ` Leo Famulari
@ 2015-12-10 3:21 ` Mathieu Lirzin
0 siblings, 0 replies; 10+ messages in thread
From: Mathieu Lirzin @ 2015-12-10 3:21 UTC (permalink / raw)
To: Leo Famulari; +Cc: guix-devel
Leo Famulari <leo@famulari.name> writes:
> Since the linked discussion is from 2009, maybe somebody should again
> try to politely submit the patch upstream.
Feel free to take the time to do it.
Thanks,
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
2015-12-10 2:57 ` Mathieu Lirzin
@ 2015-12-10 9:42 ` Ludovic Courtès
0 siblings, 0 replies; 10+ messages in thread
From: Ludovic Courtès @ 2015-12-10 9:42 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel
Mathieu Lirzin <mthl@gnu.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Mathieu Lirzin <mthl@gnu.org> skribis:
> [...]
>>> + (native-search-paths
>>> + (list (search-path-specification
>>> + (variable "TERMINFO_DIRS")
>>> + (files '("share/terminfo")))))
>>
>> This should be in the ncurses package itself, since it is “owned” by
>> ncurses, not rxvt.
>>
>> However, there’s the limitation that, currently, --search-paths
>> advertises the variables of things that are explicitly in the profile.
>> Ncurses is usually not in the profile; it is a dependency of something
>> that is in the profile. Thus, people wouldn’t see anything about
>> TERMINFO_DIRS in practice (we have the same problem with OpenSSL,
>> GStreamer, and other librairies that have associated variables.)
>>
>> Long story short, I would avoid adding this ‘native-search-paths’ here,
>> but I’m OK with it since that would make the thing usable, provided
>> there’s a big FIXME in there.
>>
>> WDYT?
>
> It makes sense. Since it is quite complicated, what about creating a
> bug report explaining the problem and make the comment refer to it like
> this:
>
> ;; FIXME: This is not located in `ncurses' for usability reasons. See
> ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=XXXXX
>
> WDYT? Can you take care of creating the bug report or propose an
> appropriate FIXME comment? I don't feel up to explaining this myself.
Good idea. It’s at <https://bugs.gnu.org/22138>.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-12-10 9:42 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-08 17:18 [PATCH] gnu: rxvt-unicode: Add the terminal capability data Mathieu Lirzin
2015-12-09 3:24 ` Leo Famulari
2015-12-09 14:12 ` Mathieu Lirzin
2015-12-09 13:52 ` Ludovic Courtès
2015-12-09 17:58 ` Mathieu Lirzin
2015-12-09 20:54 ` Ludovic Courtès
2015-12-09 21:26 ` Leo Famulari
2015-12-10 3:21 ` Mathieu Lirzin
2015-12-10 2:57 ` Mathieu Lirzin
2015-12-10 9:42 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).