From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH 4/4] gnu: samba: Update to 4.3.2.
Date: Fri, 18 Dec 2015 10:31:36 +0800
Message-ID: <87lh8strlj.fsf@member.fsf.org>
References: <1450153322-26172-1-git-send-email-iyzsong@gmail.com>
	<1450153322-26172-4-git-send-email-iyzsong@gmail.com>
	<87h9jgelj6.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35050)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1a9kpr-0002OQ-QS
	for guix-devel@gnu.org; Thu, 17 Dec 2015 21:32:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1a9kpn-0005oc-0i
	for guix-devel@gnu.org; Thu, 17 Dec 2015 21:31:59 -0500
Received: from smtp28.openmailbox.org ([62.4.1.62]:47387)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1a9kpm-0005oQ-RO
	for guix-devel@gnu.org; Thu, 17 Dec 2015 21:31:54 -0500
In-Reply-To: <87h9jgelj6.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
	=?utf-8?Q?s?= message of "Thu, 17 Dec 2015 23:51:41 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/samba.scm (samba): Update to 4.3.2.  Add more inputs.
>> [arguments]: Use 'modify-phases' syntax.
>
> Please mention the arguments removed (#:modules and #:imported-modules)
> and the phases removed.
>
> Otherwise LGTM.
Done, thanks for the review!



> Besides, I wonder if we should change it to =E2=80=98waf-build-system=E2=
=80=99.
All things from samba projects (tevent, ldb, etc.) use a custom
configure script to run its own =E2=80=9Cbuildtools/bin/waf=E2=80=9D.  And
waf-build-system expect =E2=80=9Cwaf=E2=80=9D and =E2=80=9Cwscript=E2=80=9D=
 in the same toplevel
folder, so it won=E2=80=99t work.