From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/4] gnu: samba: Update to 4.3.2.
Date: Fri, 18 Dec 2015 10:31:36 +0800 [thread overview]
Message-ID: <87lh8strlj.fsf@member.fsf.org> (raw)
In-Reply-To: <87h9jgelj6.fsf@gnu.org> ("Ludovic Courtès"'s message of "Thu, 17 Dec 2015 23:51:41 +0100")
ludo@gnu.org (Ludovic Courtès) writes:
> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/samba.scm (samba): Update to 4.3.2. Add more inputs.
>> [arguments]: Use 'modify-phases' syntax.
>
> Please mention the arguments removed (#:modules and #:imported-modules)
> and the phases removed.
>
> Otherwise LGTM.
Done, thanks for the review!
> Besides, I wonder if we should change it to ‘waf-build-system’.
All things from samba projects (tevent, ldb, etc.) use a custom
configure script to run its own “buildtools/bin/waf”. And
waf-build-system expect “waf” and “wscript” in the same toplevel
folder, so it won’t work.
next prev parent reply other threads:[~2015-12-18 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 4:21 [PATCH 1/4] gnu: talloc: Update to 2.1.5 宋文武
2015-12-15 4:22 ` [PATCH 2/4] gnu: Add tevent 宋文武
2015-12-17 22:48 ` Ludovic Courtès
2015-12-15 4:22 ` [PATCH 3/4] gnu: Add ldb 宋文武
2015-12-17 22:49 ` Ludovic Courtès
2015-12-15 4:22 ` [PATCH 4/4] gnu: samba: Update to 4.3.2 宋文武
2015-12-17 22:51 ` Ludovic Courtès
2015-12-18 2:31 ` 宋文武 [this message]
2015-12-21 13:39 ` Ludovic Courtès
2015-12-17 22:47 ` [PATCH 1/4] gnu: talloc: Update to 2.1.5 Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh8strlj.fsf@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).