From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Update Ruby to 2.3.0 Date: Sun, 10 Jan 2016 22:14:26 +0100 Message-ID: <87lh7xyw5p.fsf@gnu.org> References: <87wprqspc3.fsf@gnu.org> <5689C833.3050608@uq.edu.au> <568A4D9E.3030504@uq.edu.au> <87a8ojk6kp.fsf@gnu.org> <568F9AA9.7040605@uq.edu.au> <87wprkggjz.fsf_-_@gnu.org> <56925443.6070608@uq.edu.au> <569254F3.7070400@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aINJq-0008F9-DH for Guix-devel@gnu.org; Sun, 10 Jan 2016 16:14:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aINJl-00039O-Dk for Guix-devel@gnu.org; Sun, 10 Jan 2016 16:14:34 -0500 In-Reply-To: <569254F3.7070400@uq.edu.au> (Ben Woodcroft's message of "Sun, 10 Jan 2016 22:56:19 +1000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ben Woodcroft Cc: Guix-devel Ben Woodcroft skribis: > From 2f26295b5a163cfc5d37332a501dcba5c40fb956 Mon Sep 17 00:00:00 2001 > From: Ben Woodcroft > Date: Mon, 4 Jan 2016 09:38:42 +1000 > Subject: [PATCH 5/5] gnu: ruby: Update to 2.3.0. > > * gnu/packages/ruby.scm (ruby): Update to 2.3.0. > [arguments]: Remove bundled libffi. Use parallel tests. > (ruby-2.2): New variable. [...] > + ;; Remove bundled libffi > + (delete-file-recursively > + (string-append "ext/fiddle/libffi-3.2.1")) I should have mentioned it before, but could you move the removal to a =E2=80=98snippet=E2=80=99 in the origin? This is not critical, so if you feel like you won=E2=80=99t have time now, = we can leave that for later. Otherwise the patch is OK for =E2=80=98core-updates=E2=80=99. > From 551ecbd280eb35cb8e67cedf50e4a93f618cab1e Mon Sep 17 00:00:00 2001 > From: Ben Woodcroft > Date: Sun, 10 Jan 2016 22:25:45 +1000 > Subject: [PATCH 4/5] gnu: ruby: Use modify-phases. > > * gnu/packages/ruby.scm (ruby)[arguments]: Use modify-phases. OK. > From 015a0e17be804dd7f68f21cde8a878ff353a4a97 Mon Sep 17 00:00:00 2001 > From: Ben Woodcroft > Date: Fri, 8 Jan 2016 17:29:39 +1000 > Subject: [PATCH 3/5] ruby: Abstract out path to GEM_HOME. > > Previously paths to the GEM_HOME of certain Ruby packages were > hard-coded, so packages failed to build when Ruby was updated to 2.3.0. > > * guix/build/ruby-build-system.scm (gem-home): New procedure. > * gnu/packages/ruby.scm (ruby-metaclass, ruby-instantiator, > ruby-introspection, ruby-mocha, ruby-minitest-tu-shim): Use it. LGTM. However, ultimately, we should pass the Ruby version as a keyword parameter on the build side or have a build-side procedure akin to =E2=80=98get-python-version=E2=80=99 in python-build-system.scm (I=E2=80=99= d prefer the former.) That way, phases could query the version number of the Ruby that=E2=80=99s actually used instead of using the version number of whatever variant the global =E2=80=98ruby=E2=80=99 variable refers to. This would allow use= rs to simply change the =E2=80=9Cruby=E2=80=9D input of a package and have it automatica= lly work with the new package. Does that make sense? This can always be done after the =E2=80=98core-updates=E2=80=99 merge, no = rush. > From 048036aee522d6a03436bf530d139ec26d8a438e Mon Sep 17 00:00:00 2001 > From: Ben Woodcroft > Date: Wed, 6 Jan 2016 21:57:44 +1000 > Subject: [PATCH 2/5] gnu: ruby-yard: Disable failing test. > > * gnu/packages/ruby.scm (ruby-yard)[arguments]: Disable test which fails = on > Ruby 2.3.0. OK. > From 3918146b6179f211fb7ef955f74561f9b1460a8b Mon Sep 17 00:00:00 2001 > From: Ben Woodcroft > Date: Wed, 6 Jan 2016 21:23:15 +1000 > Subject: [PATCH 1/5] gnu: ruby-power-assert: Update to 0.2.7. > > * gnu/packages/ruby.scm (ruby-power-assert): Update to 0.2.7. OK. Thank you! Ludo=E2=80=99.