From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] gnu: Add go-1.4.
Date: Thu, 14 Jan 2016 16:12:35 +0100
Message-ID: <87lh7sp53w.fsf@gnu.org>
References: <1452616298-6255-1-git-send-email-efraim@flashner.co.il>
	<1452616298-6255-3-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:36608)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aJjZq-0003fZ-7f
	for guix-devel@gnu.org; Thu, 14 Jan 2016 10:12:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aJjZl-0003vF-7a
	for guix-devel@gnu.org; Thu, 14 Jan 2016 10:12:42 -0500
In-Reply-To: <1452616298-6255-3-git-send-email-efraim@flashner.co.il> (Efraim
	Flashner's message of "Tue, 12 Jan 2016 18:31:37 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/golang.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add golang.scm.

[...]

> +        (replace 'build
> +          (let* ((bash   (assoc-ref %build-inputs "bash"))
> +                 (gccgo  (assoc-ref %build-inputs "gccgo"))
> +                 (output (assoc-ref %outputs "out")))
> +            (setenv "CC" "gcc")
> +            (setenv "GOROOT" (getcwd))
> +            (setenv "GOROOT_BOOTSTRAP" gccgo)
> +            (setenv "GOROOT_FINAL" output)
> +            (setenv "CGO_ENABLED" "0")
> +            (lambda _
> +              ;; all.bash includes the tests, which fail because they re=
quire
> +              ;; network access, and access to /bin
> +              (zero? (system* (string-append bash "/bin/bash") "make.bas=
h")))))

Why not:

  (replace 'build
    (lambda* (#:key inputs #:allow-other-keys)
      (let ((bash =E2=80=A6) =E2=80=A6)
        =E2=80=A6
        (zero? (system* =E2=80=A6)))))

?

> +    (synopsis "Compiled, statically typed language developed by Google")
> +    (description "Go, also commonly referred to as golang, is a programm=
ing
> + language developed at Google.  Designed primarily for systems programmi=
ng, it
> + is a compiled, statically typed language in the tradition of C and C++,=
 with
> +garbage collection, various safety features and CSP-style concurrent pro=
gramming
> +features added.")

I would remove =E2=80=9Cdeveloped by Google=E2=80=9D and focus on the techn=
ical
characteristics.

Also, what=E2=80=99s CSP-style?  :-)

Thanks!

Ludo=E2=80=99.