unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 6/7] gnu: irssi: Use 'modify-phases'.
Date: Sun, 28 Feb 2016 16:48:54 +0100	[thread overview]
Message-ID: <87lh64dee1.fsf@elephly.net> (raw)
In-Reply-To: <20160228143202.GF18720@solar>


Andreas Enge <andreas@enge.fr> writes:

> ...
>
> On Sun, Feb 28, 2016 at 12:10:11PM +0200, Efraim Flashner wrote:
>> * gnu/packages/irc.scm (irssi)[arguments]: Use 'modify-phases'.
>
> Nothing to say. I think it could be combined with the previous commit,
> but this is also not a problem.
>
> ...

I think it is good to keep syntax changes separate in general, but in
this case there doesn’t seem to be much value as the whole expression is
changed anyway (due to the move to a different module).

I still have a slight preference to keep the commit separate, though.

~~ Ricardo

  reply	other threads:[~2016-02-28 15:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28 10:10 [PATCH 0/7] Add quassel irc Efraim Flashner
2016-02-28 10:10 ` [PATCH 1/7] gnu: Add oxygen-icons Efraim Flashner
2016-02-28 10:10 ` [PATCH 2/7] gnu: Add qca Efraim Flashner
2016-02-28 14:25   ` Andreas Enge
2016-02-28 10:10 ` [PATCH 3/7] gnu: Add snorenotify Efraim Flashner
2016-02-28 14:27   ` Andreas Enge
2016-02-28 10:10 ` [PATCH 4/7] gnu: Add quassel Efraim Flashner
2016-02-28 14:29   ` Andreas Enge
2016-02-28 15:50     ` Ricardo Wurmus
2016-02-28 18:46       ` Efraim Flashner
2016-02-28 10:10 ` [PATCH 5/7] gnu: irssi: Move to irc.scm Efraim Flashner
2016-02-28 14:30   ` Andreas Enge
2016-02-28 10:10 ` [PATCH 6/7] gnu: irssi: Use 'modify-phases' Efraim Flashner
2016-02-28 14:32   ` Andreas Enge
2016-02-28 15:48     ` Ricardo Wurmus [this message]
2016-02-28 10:10 ` [PATCH 7/7] gnu: weechat: Move to irc.scm Efraim Flashner
2016-02-28 14:32   ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh64dee1.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).