Re: [PATCH 2/2] gnu: Add nmap.

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

Leo Famulari <leo@famulari.name> writes:

> * gnu/packages/admin.scm (nmap): New variable.
> ---

[...]

> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "--prefix=" (assoc-ref %outputs "out"))
> +             "--without-ncat"
> +             "--without-nmap-update"
> +             "--without-zenmap")))

Could you please explain why these flags are needed?

> +    (inputs
> +     `(;("liblinear" ,liblinear)

I would just leave this off.  You already mention liblinear in a comment
above.

> +    ;; The nmap license is based on the GPL 2.0, with several exceptions and
> +    ;; modifications.  It is incompatible with the GPL 2.0.
> +    ;; Nmap's source tarball bundles the source code of many of its
> +    ;; dependencies.  This package uses nmap's modified version of libdnet and
> +    ;; liblinear, which both use a 3-clause BSD license.
> +    (license (list license:nmap license:bsd-3))))

We don’t usually explain licenses and compatibility in comments, so I
think it is not necessary to say that the nmap license is based on the
GPL but incompatible.

~~ Ricardo