unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] services: 'console-keymap-service' takes multiple files.
Date: Wed, 13 Apr 2016 23:23:03 +0200	[thread overview]
Message-ID: <87lh4hcifc.fsf@gnu.org> (raw)
In-Reply-To: <87a8l3eqhc.fsf@gmail.com> (Alex Kost's message of "Sat, 09 Apr 2016 00:32:31 +0300")

Alex Kost <alezost@gmail.com> skribis:

> From 8c58974b549479a8e97cf64f21393aa495596e13 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sat, 9 Apr 2016 00:21:15 +0300
> Subject: [PATCH] services: 'console-keymap-service' takes multiple files.
>
> * gnu/services/base.scm (console-keymap-service-type): Type procedure
> takes a list of files instead of a single file.
> (console-keymap-service): Take 'files' as rest arguments.
> * doc/guix.texi (Base Services): Improve documentation of
> 'console-keymap-service'.

[...]

> +Return a service to load console keymaps from @var{files} using
> +@command{loadkeys} command.  Most likely, you want to load some default
> +keymap, which can be done like this:
> +
> +@example
> +(console-keymap-service "dvorak")
> +@end example

Perhaps you could add the example from the IRC discussion you mentioned
with a short explanation, just below this example?

Otherwise LGTM, thanks!

Ludo’.

  parent reply	other threads:[~2016-04-13 21:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 21:32 [PATCH] services: 'console-keymap-service' takes multiple files Alex Kost
2016-04-09  8:16 ` Alex Kost
2016-04-13 21:23 ` Ludovic Courtès [this message]
2016-04-15 16:10   ` Alex Kost
2016-04-15 20:19     ` Albin
2016-04-16  8:24       ` Alex Kost
2016-04-15 21:17     ` Ludovic Courtès
2016-04-16  2:47       ` Albin
2016-04-16  8:24         ` Alex Kost
2016-04-16 14:41           ` Albin
2016-04-16 22:49             ` Ludovic Courtès
2016-04-17  7:41             ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh4hcifc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).