From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] Emacs Zenburn Date: Tue, 17 May 2016 21:10:03 +0300 Message-ID: <87lh38a744.fsf@gmail.com> References: <87a8jqqe6g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2jRb-0005PT-2P for guix-devel@gnu.org; Tue, 17 May 2016 14:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2jRV-0000KR-JA for guix-devel@gnu.org; Tue, 17 May 2016 14:10:09 -0400 Received: from mail-lb0-x242.google.com ([2a00:1450:4010:c04::242]:36154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2jRU-0000JT-UL for guix-devel@gnu.org; Tue, 17 May 2016 14:10:05 -0400 Received: by mail-lb0-x242.google.com with SMTP id r5so1455383lbj.3 for ; Tue, 17 May 2016 11:10:04 -0700 (PDT) In-Reply-To: (catonano@gmail.com's message of "Tue, 17 May 2016 12:12:41 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Catonano Cc: guix-devel@gnu.org Catonano (2016-05-17 13:12 +0300) wrote: > I made a new patch trying to adhere to your indications > > Only, I'm having troubles with git-send-email so now I'm trying to attach > the new patch to this email in a different way, maybe this time you can > access it ? Yes, perfect, thanks! > From 359d604b8cfb42726efc932a9002e7d69f439f83 Mon Sep 17 00:00:00 2001 > From: humanitiesNerd > Date: Tue, 17 May 2016 10:54:13 +0200 > Subject: [PATCH] gnu: Add emacs-zenburn-theme As I wrote in the previous message, the commit message should be: gnu: Add emacs-zenburn-theme. * gnu/packages/emacs.scm (emacs-zenburn-theme): New variable. Please keep it in mind next time ;-) > --- > gnu/packages/emacs.scm (emacs-zenburn-theme): New variable | 25 ++++++++= +++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index f0c1555..8bfcf5b 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -1590,3 +1590,28 @@ to recognize a name like \"RFC 1234\". This packa= ge enhances ffap so > that it correctly finds RFCs even when a space appears before the > number.") > (license license:gpl3+))) > + > +(define-public emacs-zenburn-theme > + (package > + (name "emacs-zenburn-theme") > + (version "2.4") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/bbatsov/zenburn-emacs/archive/v" > + version > + ".tar.gz")) "guix lint emacs-zenburn-theme" reports that =C2=ABthe source file name should contain the package name=C2=BB. This happens because (by default) this tarball has the following name in the store: /gnu/store/=E2=80=A6-v2.4.tar.gz It is better to have something more understandable, like: /gnu/store/=E2=80=A6-emacs-zenburn-theme-2.4.tar.gz This can be achieved by adding the following line to the 'origin': (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0lyi84bm8sa7vj40n6zg6rlbsmi53mi1y9xn6gkjj29s5zbcnlg7")))) > + (build-system emacs-build-system) > + (home-page "http://github.com/bbatsov/zenburn-emacs") > + (synopsis > + "Low contrast color theme for Emacs") > + (description > + "Zenburn theme is a port of the popular Vim Zenburn theme for Emacs. > +It is built on top of the custom theme support in Emacs 24 or later") > + (license license:gpl3+))) I made the mentioned changes, added a copyright line for you and committed it as 9576cc7=C2=B9. Thanks for contributing! =C2=B9 http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D9576cc72dc4f2= 973551c72951e64e5bf6240ff6b --=20 Alex