From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Jordan Subject: Re: [Patch] go@1.4 Date: Thu, 02 Jun 2016 12:29:26 -0400 Message-ID: <87lh2nh7vd.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> References: <8737p2ynsx.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> <87pos0auvd.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8VWG-0007xA-MM for guix-devel@gnu.org; Thu, 02 Jun 2016 12:30:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8VWB-0007OV-Jh for guix-devel@gnu.org; Thu, 02 Jun 2016 12:30:52 -0400 Received: from forward3o.cmail.yandex.net ([37.9.109.247]:53461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8VWA-0007ME-91 for guix-devel@gnu.org; Thu, 02 Jun 2016 12:30:47 -0400 In-reply-to: <87pos0auvd.fsf@igalia.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Andy Wingo Cc: guix-devel Hey Andy and everyone, Just a quick update, will send more details, or some patches later. Just finished up building go@1.5.4, thanks to last bit you sent. The runpath now validates in both go@1.4.3 and go@1.5.4. All enabled test now pass. >> if Linkshared { >> seenDirs := make(map[string]bool) >> seenLibs := make(map[string]bool) >> addshlib := func(path string) { >> dir, base := filepath.Split(path) >> if !seenDirs[dir] { >> argv = append(argv, "-L"+dir) >> if !rpath.set { >> argv = append(argv, "-Wl,-rpath="+dir) >> } > > This one. I do a substitute* of !rpath.set to "true" :) Personally I have no problem with it, already added some code for it. > Anyway. I think it is a sufficiently innocuous of a fix that it will > allow us to merge Go. Let us call this yak shaved and get Go in. WDYT? I'm game for anything practical, but we'll see what the reviewers have to say when I submit the updated patches. Also do you mind if I add you name and email an Co-author of these three packages? Sincerely, -- Matthew Jordan Sent with my mu4e