unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add emacs-org-bullets.
@ 2016-06-18 16:13 Ricardo Wurmus
  2016-06-19 17:10 ` Alex Kost
  0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Wurmus @ 2016-06-18 16:13 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/emacs.scm (emacs-org-bullets): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index ecefc97..d524a7c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1646,6 +1646,27 @@ that it correctly finds RFCs even when a space appears before the
 number.")
     (license license:gpl3+)))
 
+(define-public emacs-org-bullets
+  (package
+    (name "emacs-org-bullets")
+    (version "0.2.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/sabof/org-bullets/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1dyxvpb73vj80v8br2q9rf255hfphrgaw91fbvwdcd735np9pcnh"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/sabof/org-bullets")
+    (synopsis "Show bullets in org-mode as UTF-8 characters")
+    (description
+     "This package provides an Emacs theme for org-mode causing bullets to be
+rendered as UTF-8 characters.")
+    (license license:gpl3+)))
+
 (define-public emacs-zenburn-theme
   (package
     (name "emacs-zenburn-theme")
-- 
2.8.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gnu: Add emacs-org-bullets.
  2016-06-18 16:13 [PATCH] gnu: Add emacs-org-bullets Ricardo Wurmus
@ 2016-06-19 17:10 ` Alex Kost
  2016-06-20  4:30   ` Ricardo Wurmus
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Kost @ 2016-06-19 17:10 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel

Ricardo Wurmus (2016-06-18 19:13 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-org-bullets): New variable.
> ---
>  gnu/packages/emacs.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index ecefc97..d524a7c 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1646,6 +1646,27 @@ that it correctly finds RFCs even when a space appears before the
>  number.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-org-bullets
> +  (package
> +    (name "emacs-org-bullets")
> +    (version "0.2.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/sabof/org-bullets/archive/"
> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1dyxvpb73vj80v8br2q9rf255hfphrgaw91fbvwdcd735np9pcnh"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/sabof/org-bullets")
> +    (synopsis "Show bullets in org-mode as UTF-8 characters")
> +    (description
> +     "This package provides an Emacs theme for org-mode causing bullets to be
> +rendered as UTF-8 characters.")

This is not "an Emacs theme".  This package provides a minor mode
(org-bullets-mode), not a theme, so I think it's better to replace
"theme" with "minor mode" here, or something like that.

Otherwise LGTM, thanks!

> +    (license license:gpl3+)))
> +
>  (define-public emacs-zenburn-theme
>    (package
>      (name "emacs-zenburn-theme")

-- 
Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gnu: Add emacs-org-bullets.
  2016-06-19 17:10 ` Alex Kost
@ 2016-06-20  4:30   ` Ricardo Wurmus
  0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Wurmus @ 2016-06-20  4:30 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel


Alex Kost <alezost@gmail.com> writes:

> Ricardo Wurmus (2016-06-18 19:13 +0300) wrote:
>
>> * gnu/packages/emacs.scm (emacs-org-bullets): New variable.
>> ---
>>  gnu/packages/emacs.scm | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index ecefc97..d524a7c 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -1646,6 +1646,27 @@ that it correctly finds RFCs even when a space appears before the
>>  number.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-org-bullets
>> +  (package
>> +    (name "emacs-org-bullets")
>> +    (version "0.2.4")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://github.com/sabof/org-bullets/archive/"
>> +                           version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "1dyxvpb73vj80v8br2q9rf255hfphrgaw91fbvwdcd735np9pcnh"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/sabof/org-bullets")
>> +    (synopsis "Show bullets in org-mode as UTF-8 characters")
>> +    (description
>> +     "This package provides an Emacs theme for org-mode causing bullets to be
>> +rendered as UTF-8 characters.")
>
> This is not "an Emacs theme".  This package provides a minor mode
> (org-bullets-mode), not a theme, so I think it's better to replace
> "theme" with "minor mode" here, or something like that.

Okay, will do.  Thanks!

~~ Ricardo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-20  4:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-18 16:13 [PATCH] gnu: Add emacs-org-bullets Ricardo Wurmus
2016-06-19 17:10 ` Alex Kost
2016-06-20  4:30   ` Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).