unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/2] Add emacs-emms-player-mpv.
Date: Wed, 29 Jun 2016 12:02:26 +0300	[thread overview]
Message-ID: <87lh1ofjvh.fsf@gmail.com> (raw)
In-Reply-To: <20160629054549.6433-1-rekado@elephly.net> (Ricardo Wurmus's message of "Wed, 29 Jun 2016 07:45:47 +0200")

Ricardo Wurmus (2016-06-29 08:45 +0300) wrote:

> Hi Guix,
>
> I think we need to rename the “emms” package to “emacs-emms”.  (This is what
> the first patch does.)  Currently, the emacs-build-system will only add to the
> Emacs “load-path” the “site-lisp” directories of packages that start with
> “emacs-”.  I think it may be necessary to relax this requirement for cases in
> which a non-Emacs package provides an Emacs mode.

I agree!  I also think this check for "emacs-" is not needed.

> In the case of “emms”,
> however, I think renaming it is justified.

I agree, but note that there was a discussion about renaming all emacs
packages (geiser, magit, etc.) and making alisases for the old names:
<http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00316.html>

> The second patch adds an EMMS player.  The byte-compilation phase only
> succeeds after renaming “emms”, because otherwise it wouldn’t find the lisp
> files provides by that package.
>
> Ricardo Wurmus (2):
>   gnu: emms: Rename package to "emacs-emms".
>   gnu: Add emacs-emms-player-mpv.

Both patches look good to me, but I would wait for other comments about
renaming as it is not very backward compatible :-)

-- 
Alex

  parent reply	other threads:[~2016-06-29  9:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29  5:45 [PATCH 0/2] Add emacs-emms-player-mpv Ricardo Wurmus
2016-06-29  5:45 ` [PATCH 1/2] gnu: emms: Rename package to "emacs-emms" Ricardo Wurmus
2016-06-29  5:45 ` [PATCH 2/2] gnu: Add emacs-emms-player-mpv Ricardo Wurmus
2016-06-29  9:02 ` Alex Kost [this message]
2016-06-29 13:09   ` [PATCH 0/2] " Ludovic Courtès
2016-06-29 20:07     ` Ricardo Wurmus
2016-06-30 12:39       ` Ludovic Courtès
2016-07-03 16:38         ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh1ofjvh.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).