* [PATCH v3] gnu: Add python-lirc, python2-lirc.
@ 2016-08-16 21:28 Danny Milosavljevic
2016-08-16 21:41 ` Leo Famulari
0 siblings, 1 reply; 4+ messages in thread
From: Danny Milosavljevic @ 2016-08-16 21:28 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
gnu: Add python-lirc, python2-lirc.
* gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
---
gnu/packages/lirc.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-lirc-python2-lirc.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-python-lirc-python2-lirc.patch", Size: 2642 bytes --]
diff --git a/gnu/packages/lirc.scm b/gnu/packages/lirc.scm
index e3f60e3..d055bc4 100644
--- a/gnu/packages/lirc.scm
+++ b/gnu/packages/lirc.scm
@@ -19,7 +19,9 @@
(define-module (gnu packages lirc)
#:use-module (guix packages)
#:use-module (guix download)
+ #:use-module (guix git-download)
#:use-module (guix build-system gnu)
+ #:use-module (guix build-system python)
#:use-module ((guix licenses) #:prefix license:)
#:use-module (gnu packages)
#:use-module (gnu packages pkg-config)
@@ -85,3 +87,52 @@ user space applications allow you to control your computer with a remote
control: you can send X events to applications, start programs and much more
on just one button press.")
(license license:gpl2+)))
+
+(define-public python-lirc
+ (let ((commit "4091fe918f3eed2513dad008828565cace408d2f")
+ (revision "1"))
+ (package
+ (name "python-lirc")
+ (version (string-append "1.2.1-" revision "." (string-take commit 7)))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/tompreston/python-lirc.git")
+ (commit commit)))
+ (sha256
+ (base32
+ "0cm47s5pvijfs3v2k7hmpxv3mvp4n5la0ihnsczk5ym3iq166jil"))
+ (file-name (string-append name "-" version ".tar.gz"))))
+ (build-system python-build-system)
+ (inputs
+ `(("lirc" ,lirc)))
+ (native-inputs
+ `(("python-cython" ,python-cython)))
+ (arguments
+ `(#:tests? #f ; the only tests that exist are human-interactive
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'build 'build-from-cython-files
+ (lambda _
+ (zero? (system* "make" "py3")))))))
+ (home-page "https://github.com/tompreston/python-lirc")
+ (synopsis "Python bindings for LIRC.")
+ (description "@code{lirc} is a Python module which provides LIRC bindings.")
+ (license license:gpl3)
+ (properties `((python2-variant . ,(delay python2-lirc)))))))
+
+(define-public python2-lirc
+ (let ((base (package-with-python2 (strip-python2-variant python-lirc))))
+ (package
+ (inherit base)
+ (arguments
+ `(#:tests? #f ; the only tests there are are human-interactive
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'build 'build-from-cython-files
+ (lambda _
+ (zero? (system* "make" "py2")))))))
+ (native-inputs
+ `(("python2-setuptools" ,python2-setuptools)
+ ("python2-cython" ,python2-cython))))))
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.
2016-08-16 21:28 [PATCH v3] gnu: Add python-lirc, python2-lirc Danny Milosavljevic
@ 2016-08-16 21:41 ` Leo Famulari
2016-08-17 18:48 ` Alex Kost
0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2016-08-16 21:41 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote:
> gnu: Add python-lirc, python2-lirc.
>
> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
Thanks, applied as 231313f76!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.
2016-08-16 21:41 ` Leo Famulari
@ 2016-08-17 18:48 ` Alex Kost
2016-08-19 21:46 ` Leo Famulari
0 siblings, 1 reply; 4+ messages in thread
From: Alex Kost @ 2016-08-17 18:48 UTC (permalink / raw)
To: Leo Famulari; +Cc: guix-devel
Leo Famulari (2016-08-17 00:41 +0300) wrote:
> On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote:
>> gnu: Add python-lirc, python2-lirc.
>>
>> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
>
> Thanks, applied as 231313f76!
Ahem, you both are fast: I was commenting on the first patch, and
suddenly found that the third revision is already pushed :-)
Anyway, some comments:
Danny Milosavljevic (2016-08-17 00:28 +0300) wrote:
> gnu: Add python-lirc, python2-lirc.
>
> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
> ---
> gnu/packages/lirc.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
>
> diff --git a/gnu/packages/lirc.scm b/gnu/packages/lirc.scm
> index e3f60e3..d055bc4 100644
> --- a/gnu/packages/lirc.scm
> +++ b/gnu/packages/lirc.scm
> @@ -19,7 +19,9 @@
> (define-module (gnu packages lirc)
> #:use-module (guix packages)
> #:use-module (guix download)
> + #:use-module (guix git-download)
> #:use-module (guix build-system gnu)
> + #:use-module (guix build-system python)
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (gnu packages)
> #:use-module (gnu packages pkg-config)
> @@ -85,3 +87,52 @@ user space applications allow you to control your computer with a remote
> control: you can send X events to applications, start programs and much more
> on just one button press.")
> (license license:gpl2+)))
Indentation of 'python-lirc' is not perfect:
> +(define-public python-lirc
> + (let ((commit "4091fe918f3eed2513dad008828565cace408d2f")
^^
should be moved one char to the right:
> + (revision "1"))
> + (package
^^^
Likewise (you did it right in 'python2-lirc' package):
(define-public python-lirc
(let ((commit "4091fe918f3eed2513dad008828565cace408d2f")
(revision "1"))
(package ...)))
> + (name "python-lirc")
> + (version (string-append "1.2.1-" revision "." (string-take commit 7)))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/tompreston/python-lirc.git")
> + (commit commit)))
> + (sha256
> + (base32
> + "0cm47s5pvijfs3v2k7hmpxv3mvp4n5la0ihnsczk5ym3iq166jil"))
> + (file-name (string-append name "-" version ".tar.gz"))))
This is not a tarball, but a directory (git checkout) so it is a strange
name for it. We usually name such things like this:
(file-name (string-append name "-" version "-checkout"))
> + (build-system python-build-system)
> + (inputs
> + `(("lirc" ,lirc)))
> + (native-inputs
> + `(("python-cython" ,python-cython)))
> + (arguments
> + `(#:tests? #f ; the only tests that exist are human-interactive
> + #:phases
> + (modify-phases %standard-phases
^^
this (modify-phases ...) should be shifted one char left
> + (add-before 'build 'build-from-cython-files
> + (lambda _
> + (zero? (system* "make" "py3")))))))
> + (home-page "https://github.com/tompreston/python-lirc")
> + (synopsis "Python bindings for LIRC.")
> + (description "@code{lirc} is a Python module which provides LIRC bindings.")
I don't think the description should begin with "@code{lirc}" as it is
not LIRC itself but a python library for LIRC.
> + (license license:gpl3)
> + (properties `((python2-variant . ,(delay python2-lirc)))))))
> +
> +(define-public python2-lirc
> + (let ((base (package-with-python2 (strip-python2-variant python-lirc))))
> + (package
> + (inherit base)
> + (arguments
> + `(#:tests? #f ; the only tests there are are human-interactive
> + #:phases
> + (modify-phases %standard-phases
^^
the same as above
> + (add-before 'build 'build-from-cython-files
> + (lambda _
> + (zero? (system* "make" "py2")))))))
> + (native-inputs
> + `(("python2-setuptools" ,python2-setuptools)
> + ("python2-cython" ,python2-cython))))))
--
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.
2016-08-17 18:48 ` Alex Kost
@ 2016-08-19 21:46 ` Leo Famulari
0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2016-08-19 21:46 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
On Wed, Aug 17, 2016 at 09:48:47PM +0300, Alex Kost wrote:
> Leo Famulari (2016-08-17 00:41 +0300) wrote:
>
> > On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote:
> >> gnu: Add python-lirc, python2-lirc.
> >>
> >> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
> >
> > Thanks, applied as 231313f76!
>
> Ahem, you both are fast: I was commenting on the first patch, and
> suddenly found that the third revision is already pushed :-)
> Anyway, some comments:
I pushed fixes for the indentation and the misleading file-name.
> > + (description "@code{lirc} is a Python module which provides LIRC bindings.")
>
> I don't think the description should begin with "@code{lirc}" as it is
> not LIRC itself but a python library for LIRC.
Not knowing what to replace this with, I left it alone.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-19 21:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-16 21:28 [PATCH v3] gnu: Add python-lirc, python2-lirc Danny Milosavljevic
2016-08-16 21:41 ` Leo Famulari
2016-08-17 18:48 ` Alex Kost
2016-08-19 21:46 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).