From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH v3] gnu: Add python-lirc, python2-lirc. Date: Wed, 17 Aug 2016 21:48:47 +0300 Message-ID: <87lgzvqlio.fsf@gmail.com> References: <20160816212809.21436-1-dannym@scratchpost.org> <20160816214145.GA29029@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ba5tU-0007LH-GV for guix-devel@gnu.org; Wed, 17 Aug 2016 14:48:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ba5tP-0002VQ-5p for guix-devel@gnu.org; Wed, 17 Aug 2016 14:48:51 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:36593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ba5tO-0002V2-VT for guix-devel@gnu.org; Wed, 17 Aug 2016 14:48:47 -0400 Received: by mail-qt0-x244.google.com with SMTP id u25so5992241qtb.3 for ; Wed, 17 Aug 2016 11:48:46 -0700 (PDT) In-Reply-To: <20160816214145.GA29029@jasmine> (Leo Famulari's message of "Tue, 16 Aug 2016 17:41:45 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari (2016-08-17 00:41 +0300) wrote: > On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote: >> gnu: Add python-lirc, python2-lirc. >> >> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables. > > Thanks, applied as 231313f76! Ahem, you both are fast: I was commenting on the first patch, and suddenly found that the third revision is already pushed :-) Anyway, some comments: Danny Milosavljevic (2016-08-17 00:28 +0300) wrote: > gnu: Add python-lirc, python2-lirc. > > * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables. > --- > gnu/packages/lirc.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > > diff --git a/gnu/packages/lirc.scm b/gnu/packages/lirc.scm > index e3f60e3..d055bc4 100644 > --- a/gnu/packages/lirc.scm > +++ b/gnu/packages/lirc.scm > @@ -19,7 +19,9 @@ > (define-module (gnu packages lirc) > #:use-module (guix packages) > #:use-module (guix download) > + #:use-module (guix git-download) > #:use-module (guix build-system gnu) > + #:use-module (guix build-system python) > #:use-module ((guix licenses) #:prefix license:) > #:use-module (gnu packages) > #:use-module (gnu packages pkg-config) > @@ -85,3 +87,52 @@ user space applications allow you to control your computer with a remote > control: you can send X events to applications, start programs and much more > on just one button press.") > (license license:gpl2+))) Indentation of 'python-lirc' is not perfect: > +(define-public python-lirc > + (let ((commit "4091fe918f3eed2513dad008828565cace408d2f") ^^ should be moved one char to the right: > + (revision "1")) > + (package ^^^ Likewise (you did it right in 'python2-lirc' package): (define-public python-lirc (let ((commit "4091fe918f3eed2513dad008828565cace408d2f") (revision "1")) (package ...))) > + (name "python-lirc") > + (version (string-append "1.2.1-" revision "." (string-take commit 7))) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/tompreston/python-lirc.git") > + (commit commit))) > + (sha256 > + (base32 > + "0cm47s5pvijfs3v2k7hmpxv3mvp4n5la0ihnsczk5ym3iq166jil")) > + (file-name (string-append name "-" version ".tar.gz")))) This is not a tarball, but a directory (git checkout) so it is a strange name for it. We usually name such things like this: (file-name (string-append name "-" version "-checkout")) > + (build-system python-build-system) > + (inputs > + `(("lirc" ,lirc))) > + (native-inputs > + `(("python-cython" ,python-cython))) > + (arguments > + `(#:tests? #f ; the only tests that exist are human-interactive > + #:phases > + (modify-phases %standard-phases ^^ this (modify-phases ...) should be shifted one char left > + (add-before 'build 'build-from-cython-files > + (lambda _ > + (zero? (system* "make" "py3"))))))) > + (home-page "https://github.com/tompreston/python-lirc") > + (synopsis "Python bindings for LIRC.") > + (description "@code{lirc} is a Python module which provides LIRC bindings.") I don't think the description should begin with "@code{lirc}" as it is not LIRC itself but a python library for LIRC. > + (license license:gpl3) > + (properties `((python2-variant . ,(delay python2-lirc))))))) > + > +(define-public python2-lirc > + (let ((base (package-with-python2 (strip-python2-variant python-lirc)))) > + (package > + (inherit base) > + (arguments > + `(#:tests? #f ; the only tests there are are human-interactive > + #:phases > + (modify-phases %standard-phases ^^ the same as above > + (add-before 'build 'build-from-cython-files > + (lambda _ > + (zero? (system* "make" "py2"))))))) > + (native-inputs > + `(("python2-setuptools" ,python2-setuptools) > + ("python2-cython" ,python2-cython)))))) -- Alex